You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by ant elder <an...@gmail.com> on 2009/10/27 15:52:00 UTC

The maven-osgi-junit plugin version

The maven-osgi-junit plugin is problematic in that it has a hard
dependency on the Tuscany version which means it needs to be released
with every Tuscany release even though there's no change in the plugin
code itself. In the past thats not happened and I've just commented
out all the uses of the plugin in the Tuscany release, but thats not
ideal as it means the tests don't get run. The dependency is only on
node-launcher-equinox which ideally would just be picked up from the
dependencies used in the pom.xml of the module using the plugin, which
must be possible but I'm not a maven plugin expert so I don't know
how, but its also fixed by just defining the dependency in the plugin
definition, eg:

            <plugin>
                <groupId>org.apache.tuscany.maven.plugins</groupId>
                <artifactId>maven-osgi-junit-plugin</artifactId>
                <version>1.0-SNAPSHOT</version>
                <dependencies>
                   <dependency>
                      <groupId>org.apache.tuscany.sca</groupId>
                      <artifactId>tuscany-node-launcher-equinox</artifactId>
                      <version>2.0-M4-SNAPSHOT</version>
                   </dependency>
                </dependencies>
                <executions>
                    <execution>
                        <id>osgi-test</id>
                        <phase>test</phase>
                        <goals>
                            <goal>test</goal>
                        </goals>
                        <configuration></configuration>
                    </execution>
                </executions>
            </plugin>

Anyone have any comments on this or better ways to do it? If there are
no better suggestions I'd like to make that change for the M4 release
and do a release of the maven-osgi-junit-plugin that M4 can use.

   ...ant

Re: The maven-osgi-junit plugin version

Posted by ant elder <an...@apache.org>.
Smashing. So you're done with all the changes and I could release the
plugin now?

   ...ant

On Tue, Oct 27, 2009 at 4:50 PM, Raymond Feng <en...@gmail.com> wrote:
> Hi,
>
> I checked in a fix to use reflection APIs to load/start/stop the
> EquinoxHost. Now the tuscany-node-launcher-equinox is an optional runtime
> dependency which can be overridden using the plugin dependencies.
>
> Thanks,
> Raymond
> --------------------------------------------------
> From: "ant elder" <an...@gmail.com>
> Sent: Tuesday, October 27, 2009 7:52 AM
> To: <de...@tuscany.apache.org>
> Subject: The maven-osgi-junit plugin version
>
>> The maven-osgi-junit plugin is problematic in that it has a hard
>> dependency on the Tuscany version which means it needs to be released
>> with every Tuscany release even though there's no change in the plugin
>> code itself. In the past thats not happened and I've just commented
>> out all the uses of the plugin in the Tuscany release, but thats not
>> ideal as it means the tests don't get run. The dependency is only on
>> node-launcher-equinox which ideally would just be picked up from the
>> dependencies used in the pom.xml of the module using the plugin, which
>> must be possible but I'm not a maven plugin expert so I don't know
>> how, but its also fixed by just defining the dependency in the plugin
>> definition, eg:
>>
>>           <plugin>
>>               <groupId>org.apache.tuscany.maven.plugins</groupId>
>>               <artifactId>maven-osgi-junit-plugin</artifactId>
>>               <version>1.0-SNAPSHOT</version>
>>               <dependencies>
>>                  <dependency>
>>                     <groupId>org.apache.tuscany.sca</groupId>
>>
>> <artifactId>tuscany-node-launcher-equinox</artifactId>
>>                     <version>2.0-M4-SNAPSHOT</version>
>>                  </dependency>
>>               </dependencies>
>>               <executions>
>>                   <execution>
>>                       <id>osgi-test</id>
>>                       <phase>test</phase>
>>                       <goals>
>>                           <goal>test</goal>
>>                       </goals>
>>                       <configuration></configuration>
>>                   </execution>
>>               </executions>
>>           </plugin>
>>
>> Anyone have any comments on this or better ways to do it? If there are
>> no better suggestions I'd like to make that change for the M4 release
>> and do a release of the maven-osgi-junit-plugin that M4 can use.
>>
>>  ...ant
>
>

Re: The maven-osgi-junit plugin version

Posted by Raymond Feng <en...@gmail.com>.
Hi,

I checked in a fix to use reflection APIs to load/start/stop the 
EquinoxHost. Now the tuscany-node-launcher-equinox is an optional runtime 
dependency which can be overridden using the plugin dependencies.

Thanks,
Raymond
--------------------------------------------------
From: "ant elder" <an...@gmail.com>
Sent: Tuesday, October 27, 2009 7:52 AM
To: <de...@tuscany.apache.org>
Subject: The maven-osgi-junit plugin version

> The maven-osgi-junit plugin is problematic in that it has a hard
> dependency on the Tuscany version which means it needs to be released
> with every Tuscany release even though there's no change in the plugin
> code itself. In the past thats not happened and I've just commented
> out all the uses of the plugin in the Tuscany release, but thats not
> ideal as it means the tests don't get run. The dependency is only on
> node-launcher-equinox which ideally would just be picked up from the
> dependencies used in the pom.xml of the module using the plugin, which
> must be possible but I'm not a maven plugin expert so I don't know
> how, but its also fixed by just defining the dependency in the plugin
> definition, eg:
>
>            <plugin>
>                <groupId>org.apache.tuscany.maven.plugins</groupId>
>                <artifactId>maven-osgi-junit-plugin</artifactId>
>                <version>1.0-SNAPSHOT</version>
>                <dependencies>
>                   <dependency>
>                      <groupId>org.apache.tuscany.sca</groupId>
> 
> <artifactId>tuscany-node-launcher-equinox</artifactId>
>                      <version>2.0-M4-SNAPSHOT</version>
>                   </dependency>
>                </dependencies>
>                <executions>
>                    <execution>
>                        <id>osgi-test</id>
>                        <phase>test</phase>
>                        <goals>
>                            <goal>test</goal>
>                        </goals>
>                        <configuration></configuration>
>                    </execution>
>                </executions>
>            </plugin>
>
> Anyone have any comments on this or better ways to do it? If there are
> no better suggestions I'd like to make that change for the M4 release
> and do a release of the maven-osgi-junit-plugin that M4 can use.
>
>   ...ant