You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "SteveYurongSu (via GitHub)" <gi...@apache.org> on 2024/07/31 09:04:11 UTC
[PR] Pipe/Subscription: Prevent NPE when some pipe SQL parameter values are null [iotdb]
SteveYurongSu opened a new pull request, #13069:
URL: https://github.com/apache/iotdb/pull/13069
As title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Pipe/Subscription: Prevent NPE when some pipe SQL parameter values are null [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #13069:
URL: https://github.com/apache/iotdb/pull/13069#issuecomment-2260096471
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13069) **Quality Gate failed**
Failed conditions
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=13069&metric=new_coverage&view=list) (required ≥ 80%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13069)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Pipe/Subscription: Prevent NPE when some pipe SQL parameter values are null [iotdb]
Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu merged PR #13069:
URL: https://github.com/apache/iotdb/pull/13069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Pipe/Subscription: Prevent NPE when some pipe SQL parameter values are null [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #13069:
URL: https://github.com/apache/iotdb/pull/13069#issuecomment-2260204652
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/13069?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `0%` with `5 lines` in your changes missing coverage. Please review.
> Project coverage is 41.74%. Comparing base [(`7bf6eea`)](https://app.codecov.io/gh/apache/iotdb/commit/7bf6eea139c5a6ad3c0f8e56b830045a208ed125?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`5cb596f`)](https://app.codecov.io/gh/apache/iotdb/commit/5cb596f37adf0a06b127c9734b6522442e71b170?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
| [Files](https://app.codecov.io/gh/apache/iotdb/pull/13069?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../impl/subscription/topic/CreateTopicProcedure.java](https://app.codecov.io/gh/apache/iotdb/pull/13069?src=pr&el=tree&filepath=iotdb-core%2Fconfignode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fconfignode%2Fprocedure%2Fimpl%2Fsubscription%2Ftopic%2FCreateTopicProcedure.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9jb25maWdub2RlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pb3RkYi9jb25maWdub2RlL3Byb2NlZHVyZS9pbXBsL3N1YnNjcmlwdGlvbi90b3BpYy9DcmVhdGVUb3BpY1Byb2NlZHVyZS5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #13069 +/- ##
============================================
- Coverage 41.74% 41.74% -0.01%
Complexity 71 71
============================================
Files 3329 3329
Lines 211403 211399 -4
Branches 25135 25135
============================================
- Hits 88247 88242 -5
- Misses 123156 123157 +1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/13069?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org