You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/08/25 07:05:16 UTC

[GitHub] [hudi] danny0405 opened a new pull request #3535: [HUDI-2321] Use the caller classloader for ReflectionUtils

danny0405 opened a new pull request #3535:
URL: https://github.com/apache/hudi/pull/3535


   Based on the discussion on stackoverflow:
   https://stackoverflow.com/questions/1771679/difference-between-threads-context-class-loader-and-normal-classloader
   
   The Thread.currentThread().getContextClassLoader() should never be used
   because the context classloader is not immutable, user can overwrite it
   when thread switches, it is also nullable.
   
   The objection here: https://stackoverflow.com/a/36228195 says the
   Thread.currentThread().getContextClassLoader() is a JDK design error
   and the context classloader is never suggested to be used. The API that
   needs classloader should ask the user to set up the right classloader.
   
   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds quick-start document.)*
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3535: [HUDI-2321] Use the caller classloader for ReflectionUtils

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3535:
URL: https://github.com/apache/hudi/pull/3535#issuecomment-905240762


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2552e618287c46065baa96d9c2972f192fde5266",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1883",
       "triggerID" : "2552e618287c46065baa96d9c2972f192fde5266",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3349f0e888f939f1db9cb2b099a50a3bbd5e7362",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1902",
       "triggerID" : "3349f0e888f939f1db9cb2b099a50a3bbd5e7362",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2552e618287c46065baa96d9c2972f192fde5266 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1883) 
   * 3349f0e888f939f1db9cb2b099a50a3bbd5e7362 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1902) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3535: [HUDI-2321] Use the caller classloader for ReflectionUtils

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3535:
URL: https://github.com/apache/hudi/pull/3535#issuecomment-905240762


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2552e618287c46065baa96d9c2972f192fde5266",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1883",
       "triggerID" : "2552e618287c46065baa96d9c2972f192fde5266",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3349f0e888f939f1db9cb2b099a50a3bbd5e7362",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3349f0e888f939f1db9cb2b099a50a3bbd5e7362",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2552e618287c46065baa96d9c2972f192fde5266 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1883) 
   * 3349f0e888f939f1db9cb2b099a50a3bbd5e7362 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3535: [HUDI-2321] Use the caller classloader for ReflectionUtils

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3535:
URL: https://github.com/apache/hudi/pull/3535#issuecomment-905240762


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2552e618287c46065baa96d9c2972f192fde5266",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2552e618287c46065baa96d9c2972f192fde5266",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2552e618287c46065baa96d9c2972f192fde5266 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 merged pull request #3535: [HUDI-2321] Use the caller classloader for ReflectionUtils

Posted by GitBox <gi...@apache.org>.
danny0405 merged pull request #3535:
URL: https://github.com/apache/hudi/pull/3535


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3535: [HUDI-2321] Use the caller classloader for ReflectionUtils

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3535:
URL: https://github.com/apache/hudi/pull/3535#issuecomment-905240762


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2552e618287c46065baa96d9c2972f192fde5266",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1883",
       "triggerID" : "2552e618287c46065baa96d9c2972f192fde5266",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3349f0e888f939f1db9cb2b099a50a3bbd5e7362",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1902",
       "triggerID" : "3349f0e888f939f1db9cb2b099a50a3bbd5e7362",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3349f0e888f939f1db9cb2b099a50a3bbd5e7362 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1902) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3535: [HUDI-2321] Use the caller classloader for ReflectionUtils

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3535:
URL: https://github.com/apache/hudi/pull/3535#issuecomment-905240762


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2552e618287c46065baa96d9c2972f192fde5266",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1883",
       "triggerID" : "2552e618287c46065baa96d9c2972f192fde5266",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2552e618287c46065baa96d9c2972f192fde5266 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1883) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3535: [HUDI-2321] Use the caller classloader for ReflectionUtils

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3535:
URL: https://github.com/apache/hudi/pull/3535#issuecomment-905240762


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2552e618287c46065baa96d9c2972f192fde5266",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1883",
       "triggerID" : "2552e618287c46065baa96d9c2972f192fde5266",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2552e618287c46065baa96d9c2972f192fde5266 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1883) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org