You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicecomb.apache.org by GitBox <gi...@apache.org> on 2017/12/27 03:46:59 UTC

[GitHub] WillemJiang commented on a change in pull request #470: [JAV-592] Producer return completable future

WillemJiang commented on a change in pull request #470: [JAV-592] Producer return completable future
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/470#discussion_r158759160
 
 

 ##########
 File path: demo/demo-pojo/pojo-client/src/main/java/io/servicecomb/demo/pojo/client/CodeFirstPojoClient.java
 ##########
 @@ -152,7 +152,11 @@ protected void testCodeFirstIsTrue(CodeFirstPojoIntf codeFirst) {
   }
 
   protected void testCodeFirstSayHi2(CodeFirstPojoIntf codeFirst) {
-    String result = codeFirst.sayHi2("world");
+    if (!CodeFirstPojoClientIntf.class.isInstance(codeFirst)) {
 
 Review comment:
   There is a  build error in the CI.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services