You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "summaryzb (via GitHub)" <gi...@apache.org> on 2023/10/12 14:46:38 UTC
[PR] refactor: Refactor the reader code with builder pattern [incubator-uniffle]
summaryzb opened a new pull request, #1232:
URL: https://github.com/apache/incubator-uniffle/pull/1232
### What changes were proposed in this pull request?
As the title
### Why are the changes needed?
https://github.com/apache/incubator-uniffle/issues/1090
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] refactor: Refactor the reader code with builder pattern [incubator-uniffle]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1232:
URL: https://github.com/apache/incubator-uniffle/pull/1232#issuecomment-1760578023
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1232?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1232](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1232?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (575ca68) into [master](https://app.codecov.io/gh/apache/incubator-uniffle/commit/77092e48d63f38eac5bc0b429b988d56e33428fe?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (77092e4) will **increase** coverage by `0.80%`.
> The diff coverage is `68.80%`.
```diff
@@ Coverage Diff @@
## master #1232 +/- ##
============================================
+ Coverage 53.57% 54.37% +0.80%
+ Complexity 2613 2140 -473
============================================
Files 395 320 -75
Lines 22648 14689 -7959
Branches 1933 1370 -563
============================================
- Hits 12133 7987 -4146
+ Misses 9774 6252 -3522
+ Partials 741 450 -291
```
| [Files](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1232?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/uniffle/client/factory/ShuffleClientFactory.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1232?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NsaWVudC9mYWN0b3J5L1NodWZmbGVDbGllbnRGYWN0b3J5LmphdmE=) | `93.26% <98.27%> (+27.69%)` | :arrow_up: |
| [...pache/hadoop/mapreduce/task/reduce/RssShuffle.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1232?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50LW1yL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9tYXByZWR1Y2UvdGFzay9yZWR1Y2UvUnNzU2h1ZmZsZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...che/uniffle/client/impl/ShuffleReadClientImpl.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1232?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NsaWVudC9pbXBsL1NodWZmbGVSZWFkQ2xpZW50SW1wbC5qYXZh) | `76.71% <56.86%> (-1.65%)` | :arrow_down: |
... and [79 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1232/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] refactor: Refactor the reader code with builder pattern [incubator-uniffle]
Posted by "summaryzb (via GitHub)" <gi...@apache.org>.
summaryzb commented on PR #1232:
URL: https://github.com/apache/incubator-uniffle/pull/1232#issuecomment-1761349867
@jerqi PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1090] refactor: Refactor the reader code with builder pattern [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #1232:
URL: https://github.com/apache/incubator-uniffle/pull/1232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org