[GitHub] [cordova-browser] brodybits commented on issue #78: Remove Q for Native Promise

[GitBox <gi...@apache.org>]

brodybits commented on issue #78: Remove Q for Native Promise
URL: https://github.com/apache/cordova-browser/pull/78#issuecomment-501935752
 
 
   > I want to point out that this update script never checked or verified the provided project path.
   > [...]
   
   That does not sound so good. Unfortunately I cannot tell for sure what is the corresponding behavior on the other platforms.
   
   I would favor raising one or more issues to track both the behavior and level of consistency between the supported platforms.
   
   I think it should be OK to continue with this change now, and deal with that behavior whenever we can.
   
   I cannot tell whether or not this may be a breaking change. In case of any doubt, I would favor targeting this change for the next major release.
   
   And a nit that I do not favor unchecked items in the checklist. I personally do strikethrough on the items that are not needed, not sure if we have any consensus about this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org