You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "zhuqi-lucas (via GitHub)" <gi...@apache.org> on 2025/05/22 06:33:23 UTC
[PR] POC Varchar default mapping to utf8view [datafusion]
zhuqi-lucas opened a new pull request, #16142:
URL: https://github.com/apache/datafusion/pull/16142
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- Closes [#15096](https://github.com/apache/datafusion/issues/15096)
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Change default SQL mapping for `VARCAHR` from `Utf8` to `Utf8View` [datafusion]
Posted by "xudong963 (via GitHub)" <gi...@apache.org>.
xudong963 commented on PR #16142:
URL: https://github.com/apache/datafusion/pull/16142#issuecomment-2919399177
I'm reviewing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Change default SQL mapping for `VARCAHR` from `Utf8` to `Utf8View` [datafusion]
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on PR #16142:
URL: https://github.com/apache/datafusion/pull/16142#issuecomment-2914788318
> Thank you @zhuqi-lucas -- this is great
>
> FYI @jayzhan211 , @timsaucer @xudong963 and @comphead
>
> I have a few suggestions on how to simplify the examples which would be nice to get in prior to merge but I don't think it is needed
Thank you @alamb for review, i also addressed the suggestions about example in latest PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Change default SQL mapping for `VARCAHR` from `Utf8` to `Utf8View` [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #16142:
URL: https://github.com/apache/datafusion/pull/16142#issuecomment-2922372187
Thanks again @zhuqi-lucas and @xudong963
I have also made a PR to add a mention of this change to the upgrade guide:
- https://github.com/apache/datafusion/pull/16216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: varchar default mapping to utf8view [datafusion]
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on PR #16142:
URL: https://github.com/apache/datafusion/pull/16142#issuecomment-2912064010
Thank you @alamb , it seems no regression from the benchmark result!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Change default SQL mapping for `VARCAHR` from `Utf8` to `Utf8View` [datafusion]
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on code in PR #16142:
URL: https://github.com/apache/datafusion/pull/16142#discussion_r2110816666
##########
datafusion/core/tests/user_defined/user_defined_plan.rs:
##########
@@ -796,22 +798,30 @@ fn accumulate_batch(
k: &usize,
) -> BTreeMap<i64, String> {
let num_rows = input_batch.num_rows();
+
// Assuming the input columns are
- // column[0]: customer_id / UTF8
+ // column[0]: customer_id / UTF8 or UTF8View
Review Comment:
Good suggestion! Thank you @alamb , addressed in latest PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: varchar default mapping to utf8view [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #16142:
URL: https://github.com/apache/datafusion/pull/16142#issuecomment-2912049125
๐ค: Benchmark completed
<details><summary>Details</summary>
<p>
```
Comparing HEAD and varchar_default_ut8view
--------------------
Benchmark clickbench_extended.json
--------------------
โโโโโโโโโโโโโโโโณโโโโโโโโโโโโโณโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโโโโโโ
โ Query โ HEAD โ varchar_default_ut8view โ Change โ
โกโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฉ
โ QQuery 0 โ 1898.26ms โ 1810.38ms โ no change โ
โ QQuery 1 โ 658.97ms โ 670.82ms โ no change โ
โ QQuery 2 โ 1406.85ms โ 1396.48ms โ no change โ
โ QQuery 3 โ 709.94ms โ 713.90ms โ no change โ
โ QQuery 4 โ 1429.02ms โ 1398.58ms โ no change โ
โ QQuery 5 โ 15171.65ms โ 15018.76ms โ no change โ
โ QQuery 6 โ 2057.97ms โ 1992.46ms โ no change โ
โ QQuery 7 โ 2336.53ms โ 2061.27ms โ +1.13x faster โ
โ QQuery 8 โ 839.18ms โ 837.10ms โ no change โ
โโโโโโโโโโโโโโโโดโโโโโโโโโโโโโดโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโโโโ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโโโ
โ Benchmark Summary โ โ
โกโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฉ
โ Total Time (HEAD) โ 26508.38ms โ
โ Total Time (varchar_default_ut8view) โ 25899.76ms โ
โ Average Time (HEAD) โ 2945.38ms โ
โ Average Time (varchar_default_ut8view) โ 2877.75ms โ
โ Queries Faster โ 1 โ
โ Queries Slower โ 0 โ
โ Queries with No Change โ 8 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโ
--------------------
Benchmark clickbench_partitioned.json
--------------------
โโโโโโโโโโโโโโโโณโโโโโโโโโโโโโณโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโโโโโโ
โ Query โ HEAD โ varchar_default_ut8view โ Change โ
โกโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฉ
โ QQuery 0 โ 15.20ms โ 15.35ms โ no change โ
โ QQuery 1 โ 33.35ms โ 33.29ms โ no change โ
โ QQuery 2 โ 83.06ms โ 79.39ms โ no change โ
โ QQuery 3 โ 96.03ms โ 95.15ms โ no change โ
โ QQuery 4 โ 603.39ms โ 590.48ms โ no change โ
โ QQuery 5 โ 851.82ms โ 855.46ms โ no change โ
โ QQuery 6 โ 23.71ms โ 22.55ms โ no change โ
โ QQuery 7 โ 36.83ms โ 37.07ms โ no change โ
โ QQuery 8 โ 933.66ms โ 916.79ms โ no change โ
โ QQuery 9 โ 1192.79ms โ 1193.28ms โ no change โ
โ QQuery 10 โ 260.86ms โ 262.38ms โ no change โ
โ QQuery 11 โ 299.90ms โ 293.48ms โ no change โ
โ QQuery 12 โ 906.00ms โ 898.14ms โ no change โ
โ QQuery 13 โ 1344.05ms โ 1220.93ms โ +1.10x faster โ
โ QQuery 14 โ 842.98ms โ 823.52ms โ no change โ
โ QQuery 15 โ 842.44ms โ 835.95ms โ no change โ
โ QQuery 16 โ 1725.19ms โ 1718.98ms โ no change โ
โ QQuery 17 โ 1598.00ms โ 1614.71ms โ no change โ
โ QQuery 18 โ 3092.64ms โ 3093.01ms โ no change โ
โ QQuery 19 โ 81.09ms โ 81.79ms โ no change โ
โ QQuery 20 โ 1111.88ms โ 1115.69ms โ no change โ
โ QQuery 21 โ 1298.42ms โ 1296.34ms โ no change โ
โ QQuery 22 โ 2165.31ms โ 2174.91ms โ no change โ
โ QQuery 23 โ 8034.33ms โ 7921.79ms โ no change โ
โ QQuery 24 โ 458.46ms โ 457.26ms โ no change โ
โ QQuery 25 โ 391.76ms โ 372.64ms โ no change โ
โ QQuery 26 โ 528.56ms โ 519.61ms โ no change โ
โ QQuery 27 โ 1595.08ms โ 1586.78ms โ no change โ
โ QQuery 28 โ 12566.00ms โ 12405.74ms โ no change โ
โ QQuery 29 โ 535.24ms โ 532.68ms โ no change โ
โ QQuery 30 โ 796.06ms โ 807.39ms โ no change โ
โ QQuery 31 โ 863.55ms โ 857.96ms โ no change โ
โ QQuery 32 โ 2633.13ms โ 2621.41ms โ no change โ
โ QQuery 33 โ 3300.20ms โ 3347.80ms โ no change โ
โ QQuery 34 โ 3429.42ms โ 3335.38ms โ no change โ
โ QQuery 35 โ 1338.57ms โ 1340.32ms โ no change โ
โ QQuery 36 โ 123.48ms โ 118.34ms โ no change โ
โ QQuery 37 โ 55.36ms โ 56.67ms โ no change โ
โ QQuery 38 โ 119.30ms โ 117.49ms โ no change โ
โ QQuery 39 โ 191.24ms โ 187.82ms โ no change โ
โ QQuery 40 โ 46.61ms โ 47.57ms โ no change โ
โ QQuery 41 โ 45.34ms โ 44.25ms โ no change โ
โ QQuery 42 โ 39.10ms โ 38.06ms โ no change โ
โโโโโโโโโโโโโโโโดโโโโโโโโโโโโโดโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโโโโ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโโโ
โ Benchmark Summary โ โ
โกโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฉ
โ Total Time (HEAD) โ 56529.39ms โ
โ Total Time (varchar_default_ut8view) โ 55985.60ms โ
โ Average Time (HEAD) โ 1314.64ms โ
โ Average Time (varchar_default_ut8view) โ 1301.99ms โ
โ Queries Faster โ 1 โ
โ Queries Slower โ 0 โ
โ Queries with No Change โ 42 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโ
--------------------
Benchmark tpch_mem_sf1.json
--------------------
โโโโโโโโโโโโโโโโณโโโโโโโโโโโณโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโโ
โ Query โ HEAD โ varchar_default_ut8view โ Change โ
โกโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฉ
โ QQuery 1 โ 122.52ms โ 121.90ms โ no change โ
โ QQuery 2 โ 22.09ms โ 22.25ms โ no change โ
โ QQuery 3 โ 33.67ms โ 34.12ms โ no change โ
โ QQuery 4 โ 19.78ms โ 19.82ms โ no change โ
โ QQuery 5 โ 50.90ms โ 52.52ms โ no change โ
โ QQuery 6 โ 11.94ms โ 11.89ms โ no change โ
โ QQuery 7 โ 94.09ms โ 93.62ms โ no change โ
โ QQuery 8 โ 25.99ms โ 25.51ms โ no change โ
โ QQuery 9 โ 60.34ms โ 59.78ms โ no change โ
โ QQuery 10 โ 56.02ms โ 56.36ms โ no change โ
โ QQuery 11 โ 11.44ms โ 11.54ms โ no change โ
โ QQuery 12 โ 41.27ms โ 41.51ms โ no change โ
โ QQuery 13 โ 27.81ms โ 27.49ms โ no change โ
โ QQuery 14 โ 9.53ms โ 9.54ms โ no change โ
โ QQuery 15 โ 23.84ms โ 24.62ms โ no change โ
โ QQuery 16 โ 21.35ms โ 22.00ms โ no change โ
โ QQuery 17 โ 95.29ms โ 95.13ms โ no change โ
โ QQuery 18 โ 207.37ms โ 212.10ms โ no change โ
โ QQuery 19 โ 26.88ms โ 26.29ms โ no change โ
โ QQuery 20 โ 38.11ms โ 37.17ms โ no change โ
โ QQuery 21 โ 164.65ms โ 161.44ms โ no change โ
โ QQuery 22 โ 15.92ms โ 16.45ms โ no change โ
โโโโโโโโโโโโโโโโดโโโโโโโโโโโดโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโโ
โ Benchmark Summary โ โ
โกโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฉ
โ Total Time (HEAD) โ 1180.80ms โ
โ Total Time (varchar_default_ut8view) โ 1183.07ms โ
โ Average Time (HEAD) โ 53.67ms โ
โ Average Time (varchar_default_ut8view) โ 53.78ms โ
โ Queries Faster โ 0 โ
โ Queries Slower โ 0 โ
โ Queries with No Change โ 22 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโ
```
</p>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: varchar default mapping to utf8view [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #16142:
URL: https://github.com/apache/datafusion/pull/16142#issuecomment-2911938227
> Resolved all problems now including the slt testing.
>
> I think the PR is ready for benchmark progress to see if switching to Utf8View by default slows some queries down. cc @alamb Thanks a lot.
THanks @zhuqi-lucas -- I have started it up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] POC Varchar default mapping to utf8view [datafusion]
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on PR #16142:
URL: https://github.com/apache/datafusion/pull/16142#issuecomment-2900186271
Interesting, sqllogic testing successfully for my local mac but CI failed...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: varchar default mapping to utf8view [datafusion]
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on PR #16142:
URL: https://github.com/apache/datafusion/pull/16142#issuecomment-2909555117
Resolved all problems now including the slt testing.
I think the PR is ready for benchmark progress to see if switching to Utf8View by default slows some queries down. cc @alamb Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: varchar default mapping to utf8view [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #16142:
URL: https://github.com/apache/datafusion/pull/16142#issuecomment-2911937640
๐ค `./gh_compare_branch.sh` [Benchmark Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_branch.sh) Running
Linux aal-dev 6.11.0-1013-gcp #13~24.04.1-Ubuntu SMP Wed Apr 2 16:34:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing varchar_default_ut8view (5d9c537c446073c433bb4e3299bf9aa775fa0b60) to f3aed4a9bf988f5c0fdc3be845d57c0fe253cd45 [diff](https://github.com/apache/datafusion/compare/f3aed4a9bf988f5c0fdc3be845d57c0fe253cd45..5d9c537c446073c433bb4e3299bf9aa775fa0b60)
Benchmarks: tpch_mem clickbench_partitioned clickbench_extended
Results will be posted here when complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: varchar default mapping to utf8view [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #16142:
URL: https://github.com/apache/datafusion/pull/16142#discussion_r2109637172
##########
parquet-testing:
##########
Review Comment:
There appears to be an update of parquet-testing with unrelated content, but I think it is ok to update it too
##########
datafusion/core/tests/user_defined/user_defined_plan.rs:
##########
@@ -796,22 +798,30 @@ fn accumulate_batch(
k: &usize,
) -> BTreeMap<i64, String> {
let num_rows = input_batch.num_rows();
+
// Assuming the input columns are
- // column[0]: customer_id / UTF8
+ // column[0]: customer_id / UTF8 or UTF8View
Review Comment:
I feel like the example would be simpler if it just used `Utf8View`. Could we do that and avoid adding the logic to handle both types?
##########
datafusion-examples/examples/dataframe.rs:
##########
@@ -182,7 +182,11 @@ async fn write_out(ctx: &SessionContext) -> std::result::Result<(), DataFusionEr
let mut df = ctx.sql("values ('a'), ('b'), ('c')").await.unwrap();
// Ensure the column names and types match the target table
- df = df.with_column_renamed("column1", "tablecol1").unwrap();
+ df = df
Review Comment:
I think it would be better if we could change the example to maybe just use a `StringViewArray` in the first place (rather than have to cast it here)
##########
datafusion/sqllogictest/test_files/avro.slt:
##########
@@ -15,6 +15,10 @@
# specific language governing permissions and limitations
# under the License.
+# Currently, the avro not support Utf8View type, so we disable the map_varchar_to_utf8view
Review Comment:
๐
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Change default SQL mapping for `VARCAHR` from `Utf8` to `Utf8View` [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #16142:
URL: https://github.com/apache/datafusion/pull/16142#issuecomment-2916703395
I'll plan to merge this tomorrow unless I hear anything different
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Change default SQL mapping for `VARCAHR` from `Utf8` to `Utf8View` [datafusion]
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on code in PR #16142:
URL: https://github.com/apache/datafusion/pull/16142#discussion_r2110816762
##########
datafusion-examples/examples/dataframe.rs:
##########
@@ -182,7 +182,11 @@ async fn write_out(ctx: &SessionContext) -> std::result::Result<(), DataFusionEr
let mut df = ctx.sql("values ('a'), ('b'), ('c')").await.unwrap();
// Ensure the column names and types match the target table
- df = df.with_column_renamed("column1", "tablecol1").unwrap();
+ df = df
Review Comment:
Good suggestion! Thank you @alamb , addressed in latest PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Change default SQL mapping for `VARCAHR` from `Utf8` to `Utf8View` [datafusion]
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on PR #16142:
URL: https://github.com/apache/datafusion/pull/16142#issuecomment-2919746777
Thank you @xudong963 for review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Change default SQL mapping for `VARCAHR` from `Utf8` to `Utf8View` [datafusion]
Posted by "xudong963 (via GitHub)" <gi...@apache.org>.
xudong963 commented on PR #16142:
URL: https://github.com/apache/datafusion/pull/16142#issuecomment-2921292733
Let's go, thank you all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Change default SQL mapping for `VARCAHR` from `Utf8` to `Utf8View` [datafusion]
Posted by "xudong963 (via GitHub)" <gi...@apache.org>.
xudong963 merged PR #16142:
URL: https://github.com/apache/datafusion/pull/16142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org