[GitHub] [trafficserver] dragon512 commented on a change in pull request #7469: Update AuTest version update directions for pipenv

[GitBox <gi...@apache.org>]

dragon512 commented on a change in pull request #7469:
URL: https://github.com/apache/trafficserver/pull/7469#discussion_r568742649



##########
File path: tests/gold_tests/autest-site/init.cli.ext
##########
@@ -17,21 +17,29 @@
 #  limitations under the License.
 
 import sys
+import microserver
 
 if sys.version_info < (3, 6, 0):
     host.WriteError(
         "You need python 3.6 or later to run these tests\n", show_stack=False)
 
-autest_version = "1.8.1"
-if AuTestVersion() < autest_version:
+needed_autest_version = "1.8.1"
+found_autest_version = AuTestVersion()
+if AuTestVersion() < needed_autest_version:
     host.WriteError(
-        "Tests need AuTest version {needed_version} or better, found version {found_version}\n"
-        "Please update AuTest:\n  pip install --upgrade autest\n".format(
-            needed_version=autest_version,
-            found_version=AuTestVersion()),
+        f"Tests need AuTest version {needed_autest_version} or better, found version {found_autest_version}\n"
+        "Please update AuTest:\n  pipenv --rm && pipenv install\n",

Review comment:
       So my only real concern is that this test is not bound to pipenv. it more of a pip issue. as stated before the message was to update the package. Maybe I being picky but the autest.sh script and autest checks are separate items.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org