[GitHub] [spark] holdenk commented on a diff in pull request #40128: [SPARK-42466][K8S]: Cleanup k8s upload directory when job terminates

["holdenk (via GitHub)" <gi...@apache.org>]

holdenk commented on code in PR #40128:
URL: https://github.com/apache/spark/pull/40128#discussion_r1124885459


##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala:
##########
@@ -143,6 +144,9 @@ private[spark] class Client(
         logError("Please check \"kubectl auth can-i create [resource]\" first." +
           " It should be yes. And please also check your feature step implementation.")
         kubernetesClient.resourceList(preKubernetesResources: _*).delete()
+        // register shutdownhook for cleaning up the upload dir only

Review Comment:
   This is a weird place to register a shutdown hook, why not just register earlier instead of inside all of these exception cases?



##########
core/src/main/scala/org/apache/spark/UploadDirManager.scala:
##########
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark
+
+import org.apache.hadoop.fs.{FileSystem, Path}
+
+import org.apache.spark.deploy.SparkHadoopUtil
+import org.apache.spark.internal.Logging
+import org.apache.spark.util.{ShutdownHookManager, Utils}
+
+/**
+ * Kubernetes upload directory manager. It's responsible for cleanup of the upload directory
+ * when spark job finishes.
+ */
+private[spark] class UploadDirManager(conf: SparkConf, appId: String) extends Logging {

Review Comment:
   I wonder if we can share logic here with YARN? Since I imagine Spark on YARN also needs to cleanup these jars.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org