[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #4033: kvm: suspend/resume in deleting vm snapshot on kvm

[GitBox <gi...@apache.org>]

andrijapanicsb commented on a change in pull request #4033: kvm: suspend/resume in deleting vm snapshot on kvm
URL: https://github.com/apache/cloudstack/pull/4033#discussion_r409500511
 
 

 ##########
 File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtDeleteVMSnapshotCommandWrapper.java
 ##########
 @@ -58,6 +59,9 @@ public Answer execute(final DeleteVMSnapshotCommand cmd, final LibvirtComputingR
 
             snapshot = dm.snapshotLookupByName(cmd.getTarget().getSnapshotName());
 
+            s_logger.debug("Suspending domain " + vmName);
+            dm.suspend(); // suspend the vm to avoid image corruption
 
 Review comment:
   Will have to leave this for another time - otherwise, the "manually suspended" VM does indeed get's unsuspended - just managed to test it. WHY would someone in the first place even touch the VM manually, then expect ACS to handle it all?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services