You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/03/15 09:40:25 UTC

[GitHub] [submarine] yuanzac commented on a change in pull request #227: SUBMARINE-428. Add job table in db to store job status.

yuanzac commented on a change in pull request #227: SUBMARINE-428. Add job table in db to store job status.
URL: https://github.com/apache/submarine/pull/227#discussion_r392656943
 
 

 ##########
 File path: .editorconfig
 ##########
 @@ -14,7 +14,7 @@ trim_trailing_whitespace = true
 indent_style = tab
 
 # 2 space indentation
-[*.{java,sh,json,xml}]
+[*.{sh,json,xml}]
 
 Review comment:
   When a new line is added in an expression or a method defination, we need to use 4 spaces for indentation. But this configuration will use 2 spaces. This will lead an error for style checking. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services