You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Jason van Zyl <jv...@maven.org> on 2004/03/22 18:42:03 UTC
Re: cvs commit:
maven-components/maven-core/src/main/java/org/apache/maven/plugin/descriptor
PluginDescriptor.java
On Mon, 2004-03-22 at 10:10, Emmanuel Venisse wrote:
> Jason,
>
> Why you don't use constants?
This is midstream, the decision as to what instantiation strategy will
be stated in the descriptor. What I have in there currently doesn't
scale. As soon as you add a new mode it breaks. I'll fix that later
today, working on Wagon ATM.
> Emmanuel
>
> ----- Original Message -----
> From: <jv...@apache.org>
> To: <ma...@apache.org>
> Sent: Monday, March 22, 2004 3:34 PM
> Subject: cvs commit:
> maven-components/maven-core/src/main/java/org/apache/maven/plugin/descriptor
> PluginDescriptor.java
>
>
> > jvanzyl 2004/03/22 06:34:12
> >
> > Modified: maven-core/src/main/java/org/apache/maven/plugin/descriptor
> > PluginDescriptor.java
> > Log:
> >
> >
> > Revision Changes Path
> > 1.4 +2 -9
> maven-components/maven-core/src/main/java/org/apache/maven/plugin/descriptor
> /PluginDescriptor.java
> >
> > Index: PluginDescriptor.java
> > ===================================================================
> > RCS file:
> /home/cvs/maven-components/maven-core/src/main/java/org/apache/maven/plugin/
> descriptor/PluginDescriptor.java,v
> > retrieving revision 1.3
> > retrieving revision 1.4
> > diff -u -r1.3 -r1.4
> > --- PluginDescriptor.java 21 Mar 2004 13:33:58 -0000 1.3
> > +++ PluginDescriptor.java 22 Mar 2004 14:34:12 -0000 1.4
> > @@ -21,13 +21,6 @@
> >
> > import java.util.List;
> >
> > -/**
> > - *
> > - *
> > - * @author <a href="mailto:jason@maven.org">Jason van Zyl</a>
> > - *
> > - * @version $Id$
> > - */
> > public class PluginDescriptor
> > extends ComponentDescriptor
> > {
> > @@ -35,7 +28,7 @@
> >
> > private List goals;
> >
> > - private String mode = Plugin.FIELD;
> > + private String mode = "field";
> >
> > public String getRole()
> > {
> > @@ -44,7 +37,7 @@
> >
> > public String getInstantiationStrategy()
> > {
> > - if ( mode.equals( Plugin.FIELD ) || mode.equals(
> Plugin.SETTER ) )
> > + if ( mode.equals( "field" ) || mode.equals( "setter" ) )
> > {
> > return "per-lookup";
> > }
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
--
jvz.
Jason van Zyl
jason@maven.org
http://maven.apache.org
happiness is like a butterfly: the more you chase it, the more it will
elude you, but if you turn your attention to other things, it will come
and sit softly on your shoulder ...
-- Thoreau
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org