You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Zheng Shao (JIRA)" <ji...@apache.org> on 2010/02/02 04:08:21 UTC

[jira] Created: (HIVE-1122) Make ql/metadata/Table and Partition serializable

Make ql/metadata/Table and Partition serializable
-------------------------------------------------

                 Key: HIVE-1122
                 URL: https://issues.apache.org/jira/browse/HIVE-1122
             Project: Hadoop Hive
          Issue Type: Improvement
    Affects Versions: 0.6.0
            Reporter: Zheng Shao
            Assignee: Zheng Shao


Both Table and Partition are just wrappers of the thrift class TTable and TPartition.

However, Table and Partition are not serializable, and there are no guarantee in the code to make sure Table is in sync with the field of TTable.

We should make Table and Partition serializable by only serializing the TTable and TPartition fields, and we should hide the TTable details inside the Table class.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1122) Make ql/metadata/Table and Partition serializable

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-1122:
-----------------------------

    Attachment: HIVE-1122.pre.1.patch

Some preview.

> Make ql/metadata/Table and Partition serializable
> -------------------------------------------------
>
>                 Key: HIVE-1122
>                 URL: https://issues.apache.org/jira/browse/HIVE-1122
>             Project: Hadoop Hive
>          Issue Type: Improvement
>    Affects Versions: 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-1122.pre.1.patch
>
>
> Both Table and Partition are just wrappers of the thrift class TTable and TPartition.
> However, Table and Partition are not serializable, and there are no guarantee in the code to make sure Table is in sync with the field of TTable.
> We should make Table and Partition serializable by only serializing the TTable and TPartition fields, and we should hide the TTable details inside the Table class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1122) Make ql/metadata/Table and Partition serializable

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-1122:
-----------------------------

    Attachment: HIVE-1122.4.patch

This patch refactored Table.java and Partition.java to make sure these 2 classes captures all ql operations on the metastore, instead of exposing thrift Table and Partition classes directly to ql.


> Make ql/metadata/Table and Partition serializable
> -------------------------------------------------
>
>                 Key: HIVE-1122
>                 URL: https://issues.apache.org/jira/browse/HIVE-1122
>             Project: Hadoop Hive
>          Issue Type: Improvement
>    Affects Versions: 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-1122.4.patch, HIVE-1122.pre.1.patch
>
>
> Both Table and Partition are just wrappers of the thrift class TTable and TPartition.
> However, Table and Partition are not serializable, and there are no guarantee in the code to make sure Table is in sync with the field of TTable.
> We should make Table and Partition serializable by only serializing the TTable and TPartition fields, and we should hide the TTable details inside the Table class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1122) Make ql/metadata/Table and Partition serializable

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-1122:
-----------------------------

    Status: Patch Available  (was: Open)

> Make ql/metadata/Table and Partition serializable
> -------------------------------------------------
>
>                 Key: HIVE-1122
>                 URL: https://issues.apache.org/jira/browse/HIVE-1122
>             Project: Hadoop Hive
>          Issue Type: Improvement
>    Affects Versions: 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-1122.4.patch, HIVE-1122.5.patch, HIVE-1122.pre.1.patch
>
>
> Both Table and Partition are just wrappers of the thrift class TTable and TPartition.
> However, Table and Partition are not serializable, and there are no guarantee in the code to make sure Table is in sync with the field of TTable.
> We should make Table and Partition serializable by only serializing the TTable and TPartition fields, and we should hide the TTable details inside the Table class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1122) Make ql/metadata/Table and Partition serializable

Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

He Yongqiang updated HIVE-1122:
-------------------------------

      Resolution: Fixed
    Release Note: HIVE-1122. Make ql/metadata/Table and Partition serializable
          Status: Resolved  (was: Patch Available)

Committed. Thanks Zheng!

> Make ql/metadata/Table and Partition serializable
> -------------------------------------------------
>
>                 Key: HIVE-1122
>                 URL: https://issues.apache.org/jira/browse/HIVE-1122
>             Project: Hadoop Hive
>          Issue Type: Improvement
>    Affects Versions: 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-1122.4.patch, HIVE-1122.5.patch, HIVE-1122.pre.1.patch
>
>
> Both Table and Partition are just wrappers of the thrift class TTable and TPartition.
> However, Table and Partition are not serializable, and there are no guarantee in the code to make sure Table is in sync with the field of TTable.
> We should make Table and Partition serializable by only serializing the TTable and TPartition fields, and we should hide the TTable details inside the Table class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1122) Make ql/metadata/Table and Partition serializable

Posted by "Paul Yang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832347#action_12832347 ] 

Paul Yang commented on HIVE-1122:
---------------------------------

Looks good +1

> Make ql/metadata/Table and Partition serializable
> -------------------------------------------------
>
>                 Key: HIVE-1122
>                 URL: https://issues.apache.org/jira/browse/HIVE-1122
>             Project: Hadoop Hive
>          Issue Type: Improvement
>    Affects Versions: 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-1122.4.patch, HIVE-1122.5.patch, HIVE-1122.pre.1.patch
>
>
> Both Table and Partition are just wrappers of the thrift class TTable and TPartition.
> However, Table and Partition are not serializable, and there are no guarantee in the code to make sure Table is in sync with the field of TTable.
> We should make Table and Partition serializable by only serializing the TTable and TPartition fields, and we should hide the TTable details inside the Table class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1122) Make ql/metadata/Table and Partition serializable

Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carl Steinbach updated HIVE-1122:
---------------------------------

    Release Note:   (was: HIVE-1122. Make ql/metadata/Table and Partition serializable)

> Make ql/metadata/Table and Partition serializable
> -------------------------------------------------
>
>                 Key: HIVE-1122
>                 URL: https://issues.apache.org/jira/browse/HIVE-1122
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>             Fix For: 0.6.0
>
>         Attachments: HIVE-1122.4.patch, HIVE-1122.5.patch, HIVE-1122.pre.1.patch
>
>
> Both Table and Partition are just wrappers of the thrift class TTable and TPartition.
> However, Table and Partition are not serializable, and there are no guarantee in the code to make sure Table is in sync with the field of TTable.
> We should make Table and Partition serializable by only serializing the TTable and TPartition fields, and we should hide the TTable details inside the Table class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1122) Make ql/metadata/Table and Partition serializable

Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carl Steinbach updated HIVE-1122:
---------------------------------

        Fix Version/s: 0.6.0
    Affects Version/s:     (was: 0.6.0)
          Component/s: Metastore

> Make ql/metadata/Table and Partition serializable
> -------------------------------------------------
>
>                 Key: HIVE-1122
>                 URL: https://issues.apache.org/jira/browse/HIVE-1122
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>             Fix For: 0.6.0
>
>         Attachments: HIVE-1122.4.patch, HIVE-1122.5.patch, HIVE-1122.pre.1.patch
>
>
> Both Table and Partition are just wrappers of the thrift class TTable and TPartition.
> However, Table and Partition are not serializable, and there are no guarantee in the code to make sure Table is in sync with the field of TTable.
> We should make Table and Partition serializable by only serializing the TTable and TPartition fields, and we should hide the TTable details inside the Table class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1122) Make ql/metadata/Table and Partition serializable

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-1122:
-----------------------------

    Attachment: HIVE-1122.5.patch

Fixed a test error.

> Make ql/metadata/Table and Partition serializable
> -------------------------------------------------
>
>                 Key: HIVE-1122
>                 URL: https://issues.apache.org/jira/browse/HIVE-1122
>             Project: Hadoop Hive
>          Issue Type: Improvement
>    Affects Versions: 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-1122.4.patch, HIVE-1122.5.patch, HIVE-1122.pre.1.patch
>
>
> Both Table and Partition are just wrappers of the thrift class TTable and TPartition.
> However, Table and Partition are not serializable, and there are no guarantee in the code to make sure Table is in sync with the field of TTable.
> We should make Table and Partition serializable by only serializing the TTable and TPartition fields, and we should hide the TTable details inside the Table class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1122) Make ql/metadata/Table and Partition serializable

Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832349#action_12832349 ] 

He Yongqiang commented on HIVE-1122:
------------------------------------

Will test and commit

> Make ql/metadata/Table and Partition serializable
> -------------------------------------------------
>
>                 Key: HIVE-1122
>                 URL: https://issues.apache.org/jira/browse/HIVE-1122
>             Project: Hadoop Hive
>          Issue Type: Improvement
>    Affects Versions: 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-1122.4.patch, HIVE-1122.5.patch, HIVE-1122.pre.1.patch
>
>
> Both Table and Partition are just wrappers of the thrift class TTable and TPartition.
> However, Table and Partition are not serializable, and there are no guarantee in the code to make sure Table is in sync with the field of TTable.
> We should make Table and Partition serializable by only serializing the TTable and TPartition fields, and we should hide the TTable details inside the Table class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.