You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/10/13 18:30:17 UTC

[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #525: Apply Baseline to iceberg-pig

rdsr commented on a change in pull request #525: Apply Baseline to iceberg-pig
URL: https://github.com/apache/incubator-iceberg/pull/525#discussion_r334289743
 
 

 ##########
 File path: pig/src/main/java/org/apache/iceberg/pig/SchemaUtil.java
 ##########
 @@ -73,6 +60,16 @@ private static ResourceFieldSchema convert(Type type) throws IOException {
     return result;
   }
 
+  private static ResourceFieldSchema [] convertFields(List<Types.NestedField> fields) throws IOException {
 
 Review comment:
   seems like a non functional change? [method moved]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org