[GitHub] [james-project] quantranhong1999 commented on a change in pull request #761: JAMES-3534 Identity/set update + delete and Identity/get should fail for identities whose alias is deleted

[GitBox <gi...@apache.org>]

quantranhong1999 commented on a change in pull request #761:
URL: https://github.com/apache/james-project/pull/761#discussion_r758890471



##########
File path: server/data/data-jmap/src/test/scala/org/apache/james/jmap/api/identity/IdentityRepositoryTest.scala
##########
@@ -197,4 +215,17 @@ class IdentityRepositoryTest {
         htmlSignature = HtmlSignature("html 2 signature"),
         mayDelete = MayDeleteIdentity(true)))
   }
+
+  @Test
+  def updateShouldFailWhenEmailNotExists(): Unit = {

Review comment:
       whenAliasNotExists maybe?

##########
File path: server/data/data-jmap/src/test/scala/org/apache/james/jmap/api/identity/IdentityRepositoryTest.scala
##########
@@ -115,6 +115,25 @@ class IdentityRepositoryTest {
       .containsExactlyInAnyOrder(customIdentity)
   }
 
+  @Test
+  def listShouldNotReturnTheIdentityHasEmailNotExists(): Unit = {

Review comment:
       alias maybe?

##########
File path: server/data/data-jmap/src/test/scala/org/apache/james/jmap/api/identity/IdentityRepositoryTest.scala
##########
@@ -132,37 +151,34 @@ class IdentityRepositoryTest {
   }
 
   @Test
-  def updateShouldSuccessWhenCustomExists(): Unit = {
-    when(identityFactory.listIdentities(BOB)).thenReturn(List())
-    val customIdentity: Identity = SMono.fromPublisher(customIdentityDAO.save(BOB, CREATION_REQUEST)).block()
+  def updateShouldSuccessWhenCustomExistsAndEmailExists(): Unit = {

Review comment:
       updateShouldSuccessWhenCustomExistsAndAliasExists maybe?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org