[jira] [Commented] (AMBARI-1639) Customizable Dashboard for Ambari Web

["Yusaku Sako (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13677581#comment-13677581 ] 

Yusaku Sako commented on AMBARI-1639:
-------------------------------------

My feedback:

* This is a great feature to add and it was done really well!

* app/controllers/global/update_controller.js's updateServiceMetric method used to ask for specific metrics (/services?fields=components/ServiceComponentInfo,components/host_components,components/host_components/HostRoles,components/host_components/metrics/jvm/memHeapUsedM,components/host_components/metrics/jvm/memHeapCommittedM,components/host_components/metrics/mapred/jobtracker/trackers_decommissioned).  The patch is querying for /services?fields=components/ServiceComponentInfo,components/host_components,components/host_components/HostRoles,components/host_components/metrics.  It seems that doing so would significantly increase the payload since it will grab all metrics available...  We should explicitly list out all the metrics that we are asking for, like we were doing before.

* app/models/service/hdfs.js and app/models/service/mapreduce.js have unnecessary comment tags.  Please remove.

* app/templates/main/service.hbs has an empty id attribute, like so:
{code}
 <div id="" class="services-menu well span2" style="padding: 8px 0">
{code}
  Please remove this id attribute.

* ambari/ambari-web/app/messages.js - Change dashboard.customerWidgets.* to dashboard.widgets.*.  Prefixing with "customer" does not make much sense.  Change 'dashboard.customerWidgets': 'Customer Widgets' to 'dashboard.widgets': 'Cluster Status and Metrics'.

* Replace "views/main/dashboard/customer_widgets/*" with "views/main/dashboard/widgets/*".  Also, rename the directory views/main/dashboard/customer_widgets to widgets.

* vendor/scripts/jquery.ui.sortable.js
{{code}}
this._delay(function() {
  if(counter == this.counter) this.refreshPositions(!hardRefresh); //Precompute after each DOM insertion, NOT on mousemove
});
{{code}}
The above code was commented out.  Can you add a comment in this file as to why you did that?

* General comment about code format.  It does not conform to the guideline here: https://cwiki.apache.org/confluence/display/AMBARI/Coding+Guidelines+for+Ambari.  Please correct it (but only for the lines you changed).

* Certain features do not work in testMode (AMBARI-2306 was filed to track this).


                
> Customizable Dashboard for Ambari Web
> -------------------------------------
>
>                 Key: AMBARI-1639
>                 URL: https://issues.apache.org/jira/browse/AMBARI-1639
>             Project: Ambari
>          Issue Type: New Feature
>          Components: client
>    Affects Versions: 1.2.5
>            Reporter: Yusaku Sako
>            Assignee: Xi Wang
>             Fix For: 1.2.5
>
>         Attachments: AMBARI-1639.patch
>
>
> It would be great if the Ambari Web Dashboard had an inventory of widgets for showing various metrics (point-in-time values, time-series graphs, pie/donut charts, dials, histograms, etc) and allowed the user to select which ones to display and where to display them.  Also, it would be useful if the user could specify the thresholds for highlighting these metrics in different colors to alert the user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira