[jira] [Commented] (CB-11368) resolveLocalFileSystemURL cannot handle url returned by contacts plugin

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-11368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432185#comment-15432185 ] 

ASF GitHub Bot commented on CB-11368:
-------------------------------------

GitHub user matrosovN opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/192

    CB-11368 android: Resolve content URLs produced by contacts plugin

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    This PR does a safe assigment of returning value from resourceSizeForCursor to variable 'size'.
    
    ### What testing has been done on this change?
    Manual testing
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    
    This bug was happening because of invalid assignment of null value to variable of primitive type

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matrosovN/cordova-plugin-file CB-11368

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/192.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #192
    
----
commit 0bc9f912718b353bbac427ea3c614f32a104e28a
Author: Nikita Matrosov <ma...@gmail.com>
Date:   2016-08-22T17:11:24Z

    CB-11368 android: Resolve content URLs produced by contacts plugin
    
    This bug was happening because of invalid assignment of null value to variable of primitive type

----


> resolveLocalFileSystemURL cannot handle url returned by contacts plugin
> -----------------------------------------------------------------------
>
>                 Key: CB-11368
>                 URL: https://issues.apache.org/jira/browse/CB-11368
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin File
>            Reporter: zhuisui
>              Labels: triaged
>
> navigator.contacts.pickContact returns photo url like {{content://com.android.contacts/contacts/1/photo}}, which cannot be resolved by resolveLocalFileSystemURL with {{FileError code: 1000}}. I inspect code in the {{ContentFileSystem.java}}, and find the method {{resourceSizeForCursor}} cannot return correct value. The problem is, that cursor doesn't have a column named _size. I have given permission of File and Contacts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org