You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/07/19 21:15:10 UTC
[GitHub] [avro] luankevinferreira opened a new pull request, #1773: AVRO-3581: Fix Velocity configuration warnings
luankevinferreira opened a new pull request, #1773:
URL: https://github.com/apache/avro/pull/1773
Fix Velocity configuration warnings by changing to new configs since the old ones were deprecated.
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-3581
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
It only changes Velocity configs and all the tests pass after the changes.
### Commits
- [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] luankevinferreira commented on pull request #1773: AVRO-3581: Fix Velocity configuration warnings
Posted by GitBox <gi...@apache.org>.
luankevinferreira commented on PR #1773:
URL: https://github.com/apache/avro/pull/1773#issuecomment-1190356601
@martin-g actually after cleaning the cache and building a local version, I don't see warning messages anymore. I guess it was a default message with all configs that were deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g merged pull request #1773: AVRO-3581: Fix Velocity configuration warnings
Posted by GitBox <gi...@apache.org>.
martin-g merged PR #1773:
URL: https://github.com/apache/avro/pull/1773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] luankevinferreira commented on pull request #1773: AVRO-3581: Fix Velocity configuration warnings
Posted by GitBox <gi...@apache.org>.
luankevinferreira commented on PR #1773:
URL: https://github.com/apache/avro/pull/1773#issuecomment-1190222850
> The changes look good!
>
> But I wonder why your application also reports:
>
> ```
> configuration key 'file.resource.loader.path' has been deprecated in favor of 'resource.loader.file.path'
> configuration key 'space.gobbling' has been deprecated in favor of 'parser.space_gobbling'
> ```
>
> whilst those are not declared anywhere in Avro's source code. Maybe your app does it ?! Or another library in the classpath ?!
I wonder the same thing, I've searched for those configs but didn't find anything, then I thought it could be some default message since every warning message has exactly the same configs (it was printing a few times).
After creating a local version of Avro with my changes, the warning messages are still happening, probably I have another dependency that uses Velocity but I didn't find out yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1773: AVRO-3581: Fix Velocity configuration warnings
Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #1773:
URL: https://github.com/apache/avro/pull/1773#issuecomment-1191150036
Thank you for the contribution, @luankevinferreira !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org