DO NOT REPLY [Bug 34491] New: - Missing include in build.jms target results in missing class in log4j jar

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34491>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34491

           Summary: Missing include in build.jms target results in missing
                    class in log4j jar
           Product: Log4j
           Version: unspecified
          Platform: All
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Other
        AssignedTo: log4j-dev@logging.apache.org
        ReportedBy: andy.mcbride@pcmsgroup.com


The class org.apache.log4j.or.jms.MessageRenderer has never been specifically 
included in the compile sourcedirs in the build.jms target.

This has led to some variation in the inclusion of this class in the 
distributed log4j.jars:

log4j 1.0.4 - 1.2.5: MessageRenderer: class present 
log4j 1.2.6 - 1.2.7: MessageRenderer: class missing 
log4j 1.2.8:         MessageRenderer: class present 
log4j 1.2.9 - 1.3.x: MessageRenderer: class missing 

This investigation has highlighted an interesting sequence of events:

log4j 1.0.4 - 1.2.5: MessageRenderer was used in org.apache.log4.net.JMSSink 
which led to its automatic compilation
log4j 1.2.6 - 1.2.7: JMSSink modified to not use MessageRenderer, import 
remains but jdk1.3/target1.1 ignores the reference
log4j 1.2.8:       : jdk1.4/target1.2 used to build release, more agressive 
dependency analysis leads to compilation of MessageRenderer
log4j 1.2.9:       : jdk1.3/target1.1 used to build release, class missing again
log4j 1.3.6 alpha6 : jdk1.4/target1.2 used to build release, JMSSink has now 
had unused import removed so MessageRenderer not compiled

This class does not appear to be used in the current log4j codebase but I'm not 
sure if its supposed to be a part of the public API or not?

To ensure its inclusion in the distribution jar the package 
org.apache.log4j.or.jms should be specifically added to the javac include list 
in the build.jms target, the includes already exist in the jar targets.  

Patches are attached for the 1.2.9 and head branches of build.xml

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org