You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/03/31 18:52:32 UTC

[kudu-CR](branch-0.8.x) Change row projector schema equality check to use physical column type

Dan Burkert has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/2682

Change subject: Change row projector schema equality check to use physical column type
......................................................................

Change row projector schema equality check to use physical column type

The row projector uses the column's physical type (e.g. for TIMESTAMP the
physical type is INT64) to build codegen cache keys, but used the normal column
type when comparing the projection schemas retrieved from the cache. This
resulted in spurious debug check failures.

Change-Id: I5e9a8d9c003be3942d3ce6f93d880adb45d8ded6
Reviewed-on: http://gerrit.cloudera.org:8080/2672
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
(cherry picked from commit 8f4726d83e6b6b7d76c59d06fde9231f0bb113b9)
---
M src/kudu/codegen/row_projector.cc
M src/kudu/common/schema.h
2 files changed, 8 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/2682/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e9a8d9c003be3942d3ce6f93d880adb45d8ded6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-0.8.x
Gerrit-Owner: Dan Burkert <da...@cloudera.com>