You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aurora.apache.org by hsaputra <gi...@git.apache.org> on 2014/05/24 01:54:14 UTC
[GitHub] incubator-aurora pull request: Aurora 475 Remove Copyright Apache ...
GitHub user hsaputra opened a pull request:
https://github.com/apache/incubator-aurora/pull/10
Aurora 475 Remove Copyright Apache Software Foundation from the source files license header
https://reviews.apache.org/r/21882/
Some of the files have "Copyright 2013 Apache Software Foundation" in the license header comment.
This is not the right license header per ASF rule [1]
I believe the year is needed for the NOTICE file.
[1] http://www.apache.org/legal/src-headers.html
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsaputra/incubator-aurora AURORA-475
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-aurora/pull/10.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10
----
commit abeca2011569e5847c7d605f8123986b34cc6156
Author: Henry Saputra <he...@gmail.com>
Date: 2014-05-23T22:52:49Z
AURORA-475 | Remove Copyright info from ASF license source header comment.
commit 4848a95cee591caa5a8c1a6bae8bd5a281cde038
Author: Henry Saputra <he...@gmail.com>
Date: 2014-05-23T23:13:31Z
AURORA-475 Remove copyright header check Copyright with different year, like 2014 and 2013.
commit 44ddc9dd6ed549b5c2012c0da4d30292d99972e6
Author: Henry Saputra <he...@gmail.com>
Date: 2014-05-23T23:28:11Z
AURORA-475 Remove the Apache Copyright rulez for style check.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-aurora pull request: Aurora 475 Remove Copyright Apache ...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-aurora/pull/10#issuecomment-68980762
Not sure why this one was reopened. Closing it again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-aurora pull request: Aurora 475 Remove Copyright Apache ...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-aurora/pull/10#issuecomment-44071250
Just send github PR to see if it is easier to merge from GH than t
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-aurora pull request: Aurora 475 Remove Copyright Apache ...
Posted by Yasumoto <gi...@git.apache.org>.
Github user Yasumoto commented on the pull request:
https://github.com/apache/incubator-aurora/pull/10#issuecomment-55194814
This was submitted:
commit a013703
Author: Henry Saputra hsaputra@apache.org
Date: Fri May 23 23:00:18 2014 -0700
Remove the Apache Copyright rulez for style check.
Bugs closed: AURORA-475
Reviewed at https://reviews.apache.org/r/21882/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-aurora pull request: Aurora 475 Remove Copyright Apache ...
Posted by davelester <gi...@git.apache.org>.
Github user davelester commented on the pull request:
https://github.com/apache/incubator-aurora/pull/10#issuecomment-68980431
@hsaputra thanks for the contribution! As @Yasumoto noted, this was reviewed on Review Board and submitted in May. Could you close this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-aurora pull request: Aurora 475 Remove Copyright Apache ...
Posted by hsaputra <gi...@git.apache.org>.
GitHub user hsaputra reopened a pull request:
https://github.com/apache/incubator-aurora/pull/10
Aurora 475 Remove Copyright Apache Software Foundation from the source files license header
https://reviews.apache.org/r/21882/
Some of the files have "Copyright 2013 Apache Software Foundation" in the license header comment.
This is not the right license header per ASF rule [1]
I believe the year is needed for the NOTICE file.
[1] http://www.apache.org/legal/src-headers.html
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsaputra/incubator-aurora AURORA-475
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-aurora/pull/10.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10
----
commit abeca2011569e5847c7d605f8123986b34cc6156
Author: Henry Saputra <he...@gmail.com>
Date: 2014-05-23T22:52:49Z
AURORA-475 | Remove Copyright info from ASF license source header comment.
commit 4848a95cee591caa5a8c1a6bae8bd5a281cde038
Author: Henry Saputra <he...@gmail.com>
Date: 2014-05-23T23:13:31Z
AURORA-475 Remove copyright header check Copyright with different year, like 2014 and 2013.
commit 44ddc9dd6ed549b5c2012c0da4d30292d99972e6
Author: Henry Saputra <he...@gmail.com>
Date: 2014-05-23T23:28:11Z
AURORA-475 Remove the Apache Copyright rulez for style check.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-aurora pull request: Aurora 475 Remove Copyright Apache ...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra closed the pull request at:
https://github.com/apache/incubator-aurora/pull/10
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-aurora pull request: Aurora 475 Remove Copyright Apache ...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra closed the pull request at:
https://github.com/apache/incubator-aurora/pull/10
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---