You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2020/01/20 22:25:36 UTC
[GitHub] [jena] galbiston opened a new pull request #674: Geosparql
precision fixes
galbiston opened a new pull request #674: Geosparql precision fixes
URL: https://github.com/apache/jena/pull/674
Precision reduced to 6 decimal places for coordinate transformation but can be configured.
Previously failing tests now pass.
pom.xml no longer skips tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] galbiston commented on issue #674: Geosparql precision fixes
Posted by GitBox <gi...@apache.org>.
galbiston commented on issue #674: Geosparql precision fixes
URL: https://github.com/apache/jena/pull/674#issuecomment-576452376
Andy,
Since this changes the pom.xml for the GeoSPARQL module I thought you might want to check over and test.
Thanks,
Greg
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] galbiston merged pull request #674: Geosparql precision fixes
Posted by GitBox <gi...@apache.org>.
galbiston merged pull request #674: Geosparql precision fixes
URL: https://github.com/apache/jena/pull/674
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] galbiston commented on a change in pull request #674:
Geosparql precision fixes
Posted by GitBox <gi...@apache.org>.
galbiston commented on a change in pull request #674: Geosparql precision fixes
URL: https://github.com/apache/jena/pull/674#discussion_r371428372
##########
File path: jena-geosparql/pom.xml
##########
@@ -105,7 +105,7 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
- <skip>true</skip>
+ <skip>false</skip>
Review comment:
I've removed the `surefire` plugin configuration block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] rvesse commented on a change in pull request #674: Geosparql
precision fixes
Posted by GitBox <gi...@apache.org>.
rvesse commented on a change in pull request #674: Geosparql precision fixes
URL: https://github.com/apache/jena/pull/674#discussion_r368891352
##########
File path: jena-geosparql/pom.xml
##########
@@ -105,7 +105,7 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
- <skip>true</skip>
+ <skip>false</skip>
Review comment:
If we're no longer skipping we should remove this configuration entirely as otherwise it may prevent end users from opting in to skip tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org