You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/06/13 16:44:14 UTC
[PR] Fix clippy for object_store [arrow-rs]
alamb opened a new pull request, #5883:
URL: https://github.com/apache/arrow-rs/pull/5883
More fallout from the most recent rust release
@XiangpengHao fixed most of the others in https://github.com/apache/arrow-rs/pull/5881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix clippy for object_store [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5883:
URL: https://github.com/apache/arrow-rs/pull/5883#discussion_r1638720494
##########
object_store/src/aws/credential.rs:
##########
@@ -424,6 +424,7 @@ fn canonicalize_headers(header_map: &HeaderMap) -> (String, String) {
/// <https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/configuring-instance-metadata-service.html>
#[derive(Debug)]
pub struct InstanceCredentialProvider {
+ #[allow(dead_code)]
Review Comment:
```suggestion
// https://github.com/apache/arrow-rs/issues/5884
#[allow(dead_code)]
```
##########
object_store/src/aws/credential.rs:
##########
@@ -424,6 +424,7 @@ fn canonicalize_headers(header_map: &HeaderMap) -> (String, String) {
/// <https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/configuring-instance-metadata-service.html>
#[derive(Debug)]
pub struct InstanceCredentialProvider {
+ #[allow(dead_code)]
Review Comment:
Filed https://github.com/apache/arrow-rs/issues/5884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix clippy for object_store [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5883:
URL: https://github.com/apache/arrow-rs/pull/5883#issuecomment-2166552666
Thank you for the review @Xuanwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix clippy for object_store [arrow-rs]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #5883:
URL: https://github.com/apache/arrow-rs/pull/5883#discussion_r1638538556
##########
object_store/src/aws/credential.rs:
##########
@@ -424,6 +424,7 @@ fn canonicalize_headers(header_map: &HeaderMap) -> (String, String) {
/// <https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/configuring-instance-metadata-service.html>
#[derive(Debug)]
pub struct InstanceCredentialProvider {
+ #[allow(dead_code)]
Review Comment:
Would you like to create an issue for this? I feel like we've overlooked something here that prevents `cache` from ever being used. I'm willing to get it fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix clippy for object_store [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5883:
URL: https://github.com/apache/arrow-rs/pull/5883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org