Re: [PR] HDDS-15766. Make Recon OM DB large tarball transfer reliable [ozone]

["priyeshkaratha (via GitHub)" <gi...@apache.org>]

priyeshkaratha commented on code in PR #10696:
URL: https://github.com/apache/ozone/pull/10696#discussion_r3575957609


##########
hadoop-ozone/recon/pom.xml:
##########
@@ -138,6 +138,10 @@
       <groupId>org.apache.hadoop</groupId>
       <artifactId>hadoop-hdfs-client</artifactId>
     </dependency>
+    <dependency>

Review Comment:
   Can avoid adding this dependency since it is used only to use URIBuilder in buildCheckpointUrl?



##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/RDBSnapshotProvider.java:
##########
@@ -126,7 +126,7 @@ public DBCheckpoint downloadDBSnapshotFromLeader(String leaderNodeID)
       LOG.info("Successfully untar the downloaded snapshot {} at {}.",
           targetFile, unTarredDb.toAbsolutePath());
       if (ratisSnapshotComplete(unTarredDb)) {
-        LOG.info("Ratis snapshot transfer is complete.");
+        LOG.info("DB snapshot transfer is complete.");

Review Comment:
   These log changes will also impact the OM follower logs. Do we really need this change? The existing check for ratisSnapshotComplete already aligns with the info logs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org