[GitHub] [pinot] walterddr commented on a diff in pull request #10319: [multistage] Close OpChains That Return Error-Block

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #10319:
URL: https://github.com/apache/pinot/pull/10319#discussion_r1114987353


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/OpChainSchedulerService.java:
##########
@@ -100,6 +102,7 @@ public void runJob() {
             if (isFinished) {
               closeOpChain(operatorChain);
             } else if (thrown != null) {
+              // TODO: It would make sense to cancel OpChains if they returned an error-block.

Review Comment:
   won't `isFinished` be set to true if opChain returns an error block?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org