[GitHub] [spark] s1ck commented on a change in pull request #24490: [SPARK-27300][GRAPH][test-maven] Add Spark Graph modules and dependencies

[GitBox <gi...@apache.org>]

s1ck commented on a change in pull request #24490: [SPARK-27300][GRAPH][test-maven] Add Spark Graph modules and dependencies
URL: https://github.com/apache/spark/pull/24490#discussion_r279952133
 
 

 ##########
 File path: dev/deps/spark-deps-hadoop-2.7
 ##########
 @@ -17,13 +18,17 @@ arpack_combined_all-0.1.jar
 arrow-format-0.12.0.jar
 arrow-memory-0.12.0.jar
 arrow-vector-0.12.0.jar
+ast-9.0-9.0.20190305.jar
 automaton-1.11-8.jar
 avro-1.8.2.jar
 avro-ipc-1.8.2.jar
 avro-mapred-1.8.2-hadoop2.jar
 bonecp-0.8.0.RELEASE.jar
 breeze-macros_2.12-0.13.2.jar
 breeze_2.12-0.13.2.jar
+cats-core_2.12-1.6.0.jar
+cats-kernel_2.12-1.6.0.jar
+cats-macros_2.12-1.6.0.jar
 
 Review comment:
   Those dependencies are part of the OKAPI stack which is responsible for translating Cypher to relational operations. I understand that adding a lot of dependencies is bad practice for a single PR. By excluding them, we basically require the user to add explicit dependencies? If yes, it doesn't sound like an elegant solution to me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org