[GitHub] [accumulo] ctubbsii commented on a change in pull request #1706: Related #1664. Allow Candidate batch size to be user configurable

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1706:
URL: https://github.com/apache/accumulo/pull/1706#discussion_r489637965



##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -568,6 +568,8 @@
   // accumulo garbage collector properties
   GC_PREFIX("gc.", null, PropertyType.PREFIX,
       "Properties in this category affect the behavior of the accumulo garbage collector."),
+  GC_CANDIDATE_BATCH_SIZE("gc.candidate.batch.size", "4000000", PropertyType.COUNT,
+          "The batch size used for garbage collection. The default is effectively 8MB"),

Review comment:
       If we make this property of type `PropertyType.BYTES`, then it may be more user friendly, and the comment about the default can be removed, because it would be redundant. If you do that, then it's a simple matter to divide by 2 to get the approximate number of characters for the count in the implementation. Using `PropertyType.BYTES` will also make it more user friendly, because users can use the typed-strings, like `16M` or `1G` or `512K` when they change the configuration (and the default can be `8M`).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org