You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/03 06:37:29 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #25296: Only load distribution of a name once

uranusjr commented on code in PR #25296:
URL: https://github.com/apache/airflow/pull/25296#discussion_r936287827


##########
airflow/plugins_manager.py:
##########
@@ -113,7 +113,7 @@ class EntryPointSource(AirflowPluginSource):
     """Class used to define Plugins loaded from entrypoint."""
 
     def __init__(self, entrypoint: importlib_metadata.EntryPoint, dist: importlib_metadata.Distribution):
-        self.dist = dist.metadata['name']
+        self.dist = dist.metadata['Name']

Review Comment:
   Python pacakge metadata keys are case-insensitive, I use `Name` ([the case used by the standard](https://packaging.python.org/en/latest/specifications/core-metadata/)) everywhere so tests are easier to write.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org