You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/03/17 08:13:24 UTC

[GitHub] [pulsar] freeznet edited a comment on pull request #9907: [fix #9851] Add forwardSourceMessageProperty to SourceConfig

freeznet edited a comment on pull request #9907:
URL: https://github.com/apache/pulsar/pull/9907#issuecomment-800886581


   > @freeznet since this is a bug fix and seems that it is related to internal implementations, think we do not need to update the Pulsar user guides, correct?
   
   @Anonymitaet i dont think we need to update the Pulsar user guides, but we can add some notes to [http://pulsar.apache.org/docs/en/next/io-develop/#source](http://pulsar.apache.org/docs/en/next/io-develop/#source), within `Implement the read method.` - `Record should provide the following variables:` - `Properties` part. 
   
   Also we need to add newly added argument `--forward-source-message-property` to [http://pulsar.apache.org/docs/en/next/io-cli/#create](http://pulsar.apache.org/docs/en/next/io-cli/#create) and [http://pulsar.apache.org/docs/en/next/io-cli/#localrun](http://pulsar.apache.org/docs/en/next/io-cli/#localrun) as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org