You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/29 07:42:33 UTC
[GitHub] [pulsar] 315157973 opened a new pull request #7094: fix Pulsar supporting DLQ for sources/sinks #7032
315157973 opened a new pull request #7094:
URL: https://github.com/apache/pulsar/pull/7094
Fixes #7032
### Motivation
Source data flow:
Custom Source-> Function-> Pulsar producer-> Broker
Sink data flow:
Broker-> Pulsar consumer-> Function-> Custom Sink
Pulsar consumer is only used in sink mode, so it is necessary to add DLQ parameters for sink mode
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ADHB commented on pull request #7094: fix Pulsar supporting DLQ for sources/sinks #7032
Posted by GitBox <gi...@apache.org>.
ADHB commented on pull request #7094:
URL: https://github.com/apache/pulsar/pull/7094#issuecomment-636377080
I meant 2.6.0 yes. Ok thanks for your answer .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ADHB commented on pull request #7094: fix Pulsar supporting DLQ for sources/sinks #7032
Posted by GitBox <gi...@apache.org>.
ADHB commented on pull request #7094:
URL: https://github.com/apache/pulsar/pull/7094#issuecomment-636307627
Hi guys. Can you please explain what this merge means? Should we wait for 7.6.0. to test DLQ with sinks or it's already implemented under 7.5.2.? Also, is there (or will be) any documentation regarding the new use? Thanks for the fast work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ADHB edited a comment on pull request #7094: fix Pulsar supporting DLQ for sources/sinks #7032
Posted by GitBox <gi...@apache.org>.
ADHB edited a comment on pull request #7094:
URL: https://github.com/apache/pulsar/pull/7094#issuecomment-636307627
Hi guys. Can you please explain what this merge means? Should we wait for 2.6.0. to test DLQ with sinks or it's already implemented under 2.5.3.? Also, is there (or will be) any documentation regarding the new use? Thanks for the fast work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai merged pull request #7094: fix Pulsar supporting DLQ for sources/sinks #7032
Posted by GitBox <gi...@apache.org>.
jiazhai merged pull request #7094:
URL: https://github.com/apache/pulsar/pull/7094
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #7094: fix Pulsar supporting DLQ for sources/sinks #7032
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #7094:
URL: https://github.com/apache/pulsar/pull/7094#issuecomment-636365836
@ADHB
What does 7.5.2 or 7.6.0 mean here? Do you mean 2.5.2 or 2.6.0?
This change is merged to master and will be released as part of 2.6.0 and 2.5.3 (if we release it).
I have labeled it as `doc-required`. @315157973 or @Anonymitaet can help add the documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org