You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/29 14:41:59 UTC

[GitHub] [yunikorn-k8shim] pbacsko commented on a change in pull request #400: [YUNIKORN-1152] Make sure that --placeHolderImage switch is always properly set

pbacsko commented on a change in pull request #400:
URL: https://github.com/apache/yunikorn-k8shim/pull/400#discussion_r837562519



##########
File path: pkg/schedulerplugin/conf/pluginconf.go
##########
@@ -132,6 +132,8 @@ func NewSchedulerConf() *conf.SchedulerConf {
 			configuration.UserLabelKey = getStringArg(flag, constants.DefaultUserLabel)
 		case ArgOperatorPlugins:
 			configuration.OperatorPlugins = getStringArg(flag, "general,"+constants.AppManagerHandlerName)
+		case ArgPlaceHolderImage:
+			configuration.PlaceHolderImage = getStringArg(flag, constants.PlaceholderContainerImage)

Review comment:
       This was missing from the original change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org