[GitHub] [hudi] nsivabalan commented on a change in pull request #3762: [HUDI-1294] Adding inline read and seek based read(batch get) for hfile log blocks in metadata table

[GitBox <gi...@apache.org>]

nsivabalan commented on a change in pull request #3762:
URL: https://github.com/apache/hudi/pull/3762#discussion_r728244437



##########
File path: hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java
##########
@@ -126,23 +130,21 @@ protected BaseTableMetadata(HoodieEngineContext engineContext, HoodieMetadataCon
   }
 
   @Override
-  public Map<String, FileStatus[]> getAllFilesInPartitions(List<String> partitionPaths)
+  public Map<String, FileStatus[]> getAllFilesInPartitions(List<String> partitions)
       throws IOException {
     if (enabled) {
-      Map<String, FileStatus[]> partitionsFilesMap = new HashMap<>();
-
       try {
-        for (String partitionPath : partitionPaths) {
-          partitionsFilesMap.put(partitionPath, fetchAllFilesInPartition(new Path(partitionPath)));
-        }
+        // need to understand why we did not make bulk get before

Review comment:
       @prashantwason @satishkotha : do you guys know why we did not do batch get here and doing 1 key at a time? is there any particular reason for it. I have fixed it to fetch batch get in this patch.  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org