You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <de...@bloodhound.apache.org> on 2013/07/03 10:29:22 UTC
[Apache Bloodhound] #583: Adapt to new ThemeEnginePlugin API (2.2.0)
#583: Adapt to new ThemeEnginePlugin API (2.2.0)
--------------------------+---------------
Reporter: rjollos | Owner:
Type: enhancement | Status: new
Priority: major | Version:
Resolution: |
--------------------------+---------------
With [th:ThemeEnginePlugin] version 2.2.0, the following error is seen in
the logs:
{{{
01:20:43 AM Trac[web_ui] WARNING: Theme Bloodhound template overrides :
AttributeError: 'BloodhoundTheme' object has no attribute
'get_template_overrides'
}}}
It is harmless at the moment as far as I can see, but we should eventually
adapt to the new [th:ThemeEnginePlugin] API. See [th 13169].
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/583>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #583: Adapt to new ThemeEnginePlugin API
(2.2.0)
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#583: Adapt to new ThemeEnginePlugin API (2.2.0)
--------------------------+-------------------------
Reporter: rjollos | Owner: nobody
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: plugins | Version:
Resolution: | Keywords: themeengine
--------------------------+-------------------------
Changes (by rjollos):
* owner: => nobody
* priority: major => minor
* component: => plugins
* keywords: => themeengine
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/583#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #583: Adapt to new ThemeEnginePlugin API
(2.2.0)
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#583: Adapt to new ThemeEnginePlugin API (2.2.0)
--------------------------+--------------------------------
Reporter: rjollos | Owner: rjollos
Type: enhancement | Status: review
Priority: minor | Milestone: Release 8
Component: plugins | Version:
Resolution: | Keywords: themeengine plugin
--------------------------+--------------------------------
Changes (by rjollos):
* owner: olemis => rjollos
* status: accepted => review
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/583#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #583: Adapt to new ThemeEnginePlugin API
(2.2.0)
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#583: Adapt to new ThemeEnginePlugin API (2.2.0)
--------------------------+--------------------------------
Reporter: rjollos | Owner: olemis
Type: enhancement | Status: assigned
Priority: minor | Milestone: Release 9
Component: ui design | Version: 0.6.0
Resolution: | Keywords: themeengine plugin
--------------------------+--------------------------------
Comment (by olemis):
Details to apply the quick fix
{{{#!sh
$ hg qapplied
t583/t583_r1516428_template_overrides_quickfix.diff
$ hg log -r qparent
changeset: 393:a9131b7a9ff9
tag: qparent
tag: svn-1515319
parent: 389:f4d8a6aaee48
user: rjollos@13f79535-47bb-0310-9956-ffa450edef68
date: Mon Aug 19 08:43:06 2013 +0000
summary: Bumped package version numbers for the next release.
}}}
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/583#comment:8>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #583: Adapt to new ThemeEnginePlugin API
(2.2.0)
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#583: Adapt to new ThemeEnginePlugin API (2.2.0)
--------------------------+--------------------------------
Reporter: rjollos | Owner: olemis
Type: enhancement | Status: assigned
Priority: minor | Milestone: Release 9
Component: ui design | Version: 0.6.0
Resolution: | Keywords: themeengine plugin
--------------------------+--------------------------------
Comment (by olemis):
... however, since this seems to be a generic situation quite often
happening in practice then I added aforementioned changes in `ThemeBase`
class , see th:changeset:13362 . By upgrading trachacks:ThemeEnginePlugin
to version 2.2.1 empty template overrides will be inherited by
`BloodhoundTheme` .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/583#comment:9>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #583: Adapt to new ThemeEnginePlugin API
(2.2.0)
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#583: Adapt to new ThemeEnginePlugin API (2.2.0)
--------------------------+--------------------------------
Reporter: rjollos | Owner: nobody
Type: enhancement | Status: new
Priority: minor | Milestone: Release 7
Component: plugins | Version:
Resolution: | Keywords: themeengine plugin
--------------------------+--------------------------------
Changes (by rjollos):
* keywords: themeengine => themeengine plugin
* milestone: => Release 7
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/583#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #583: Adapt to new ThemeEnginePlugin API
(2.2.0)
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#583: Adapt to new ThemeEnginePlugin API (2.2.0)
--------------------------+--------------------------------
Reporter: rjollos | Owner: olemis
Type: enhancement | Status: assigned
Priority: minor | Milestone: Release 9
Component: ui design | Version: 0.6.0
Resolution: | Keywords: themeengine plugin
--------------------------+--------------------------------
Changes (by olemis):
* version: => 0.6.0
* component: plugins => ui design
* milestone: Release 8 => Release 9
Comment:
What I propose to do about this is to apply
[attachment:t583_r1516428_template_overrides.diff this patch] so as to not
emit the warning to the logs and keep everything else the way it is now,
thus deferring a more in-depth integration until [milestone:"Release 9"] .
AFAICT there are more important issues to deal with atm , and adoption of
the new API is not as straight forward as I initially thought .
I've updated ticket fields accordingly . Feel free to revert changes if
this is at all or partially wrong.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/583#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #583: Adapt to new ThemeEnginePlugin API
(2.2.0)
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#583: Adapt to new ThemeEnginePlugin API (2.2.0)
--------------------------+--------------------------------
Reporter: rjollos | Owner: olemis
Type: enhancement | Status: accepted
Priority: minor | Milestone: Release 7
Component: plugins | Version:
Resolution: | Keywords: themeengine plugin
--------------------------+--------------------------------
Changes (by olemis):
* status: new => accepted
* owner: nobody => olemis
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/583#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #583: Adapt to new ThemeEnginePlugin API
(2.2.0)
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#583: Adapt to new ThemeEnginePlugin API (2.2.0)
--------------------------+--------------------------------
Reporter: rjollos | Owner: olemis
Type: enhancement | Status: assigned
Priority: minor | Milestone: Release 8
Component: plugins | Version:
Resolution: | Keywords: themeengine plugin
--------------------------+--------------------------------
Changes (by olemis):
* status: review => assigned
* owner: rjollos => olemis
Comment:
@rjollos : I had not put this ticket into review state because it's not
quite ready . Submitted patches still do not improve the situation . There
a number of pending issues related to this and I'm in the process of
assessing what should be the logical continuation / finalization for this
ticket .
Therefore I'm reverting your changes in comment:5
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/583#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker