[GitHub] [rocketmq-externals] duhenglucky commented on a change in pull request #370: [ISSUE #371]Develop Jdbc Source Connector

[GitBox <gi...@apache.org>]

duhenglucky commented on a change in pull request #370: [ISSUE #371]Develop Jdbc Source Connector
URL: https://github.com/apache/rocketmq-externals/pull/370#discussion_r314552921
 
 

 ##########
 File path: rocketmq-connect-jdbc/src/test/java/org/apache/rocketmq/connect/jdbc/connector/JdbcSourceTaskTest.java
 ##########
 @@ -16,29 +16,88 @@
  */
 
 package org.apache.rocketmq.connect.jdbc.connector;
+
 import java.util.Collection;
-import org.junit.Test;
+import java.util.HashMap;
+import java.util.Map;
+
+import javax.sql.DataSource;
 
+import org.junit.Test;
+import java.sql.*;
+import com.alibaba.druid.pool.DruidDataSourceFactory;
 
 import io.openmessaging.KeyValue;
+import io.openmessaging.connector.api.Task;
 import io.openmessaging.connector.api.data.SourceDataEntry;
 import io.openmessaging.internal.DefaultKeyValue;
 
 public class JdbcSourceTaskTest {
+	KeyValue kv;
+	DataSource dataSource;
+
+	@Test
+	public void testBulk() throws InterruptedException {
 
 Review comment:
   Please mock the real database connection in unite test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services