You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/02/26 16:24:23 UTC
[GitHub] [iotdb] weizihan0110 opened a new pull request #2744: remove redundant call of sealCurrentPage().
weizihan0110 opened a new pull request #2744:
URL: https://github.com/apache/iotdb/pull/2744
Call sealCurrentPage() method twice:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on a change in pull request #2744: remove redundant call of sealCurrentPage().
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on a change in pull request #2744:
URL: https://github.com/apache/iotdb/pull/2744#discussion_r584012503
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/flush/MemTableFlushTask.java
##########
@@ -271,7 +270,7 @@ public void run() {
storageGroup,
writer.getFile().getName());
while (true) {
- Object ioMessage = null;
Review comment:
local var init...this do not have problem...
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/flush/MemTableFlushTask.java
##########
@@ -237,7 +237,6 @@ public void run() {
(Pair<TVList, MeasurementSchema>) task;
IChunkWriter seriesWriter = new ChunkWriterImpl(encodingMessage.right);
writeOneSeries(encodingMessage.left, seriesWriter, encodingMessage.right.getType());
- seriesWriter.sealCurrentPage();
Review comment:
this code can not delete. because this method make encode data...
this will lead to encode problem...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] weizihan0110 closed pull request #2744: remove redundant call of sealCurrentPage().
Posted by GitBox <gi...@apache.org>.
weizihan0110 closed pull request #2744:
URL: https://github.com/apache/iotdb/pull/2744
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org