You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/04/21 16:37:33 UTC

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9058: Add some network-related definitions

xiaoxiang781216 commented on code in PR #9058:
URL: https://github.com/apache/nuttx/pull/9058#discussion_r1173972123


##########
include/net/ethernet.h:
##########
@@ -33,6 +33,10 @@
 
 #define ETHER_ADDR_LEN  6
 
+#define ETHERTYPE_ARP   0x0806 /* Address resolution protocol */
+#define ETHERTYPE_IP    0x0800 /* IP */
+#define ETHERTYPE_IPV6  0x86dd /* IP protocol version 6 */

Review Comment:
   If no conflict happens, what's benefit to add option?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org