[GitHub] limited closed pull request #1792: changed maxLength of zip code to be longer.

[GitBox <gi...@apache.org>]

limited closed pull request #1792: changed maxLength of zip code to be longer.
URL: https://github.com/apache/incubator-trafficcontrol/pull/1792
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/traffic_ops/app/lib/UI/PhysLocation.pm b/traffic_ops/app/lib/UI/PhysLocation.pm
index 54a643d89c..258c1aab47 100644
--- a/traffic_ops/app/lib/UI/PhysLocation.pm
+++ b/traffic_ops/app/lib/UI/PhysLocation.pm
@@ -345,7 +345,6 @@ sub is_valid {
 	$self->field('location.address')->is_required->is_like( qr/^[a-zA-Z0-9\ \.\-]+/, "Use alphanumeric characters, '.','-', or space." );
 	$self->field('location.city')->is_required->is_like( qr/^[a-zA-Z0-9\ \.\-]+/, "Use alphanumeric characters, '.','-', or space." );
 	$self->field('location.state')->is_required->is_like( qr/^[A-Z]{2}/, "Uppercase 2 char. state abbreviation." );
-	$self->field('location.zip')->is_required->is_like( qr/^[0-9]{5,5}$/, "Enter a valid 5 digit zipcode." );
 	$self->field('location.phone')->is_like( qr/^$|[0-9]{3}\-[0-9]{3}\-[0-9]{4}/, "Phone number format is: ###-###-####" );
 	$self->field('location.email')->check( sub {
 			my ( $value, $params ) = @_;
diff --git a/traffic_portal/app/src/common/modules/form/physLocation/FormPhysLocationController.js b/traffic_portal/app/src/common/modules/form/physLocation/FormPhysLocationController.js
index d7f78fcfd7..a0ed71e624 100644
--- a/traffic_portal/app/src/common/modules/form/physLocation/FormPhysLocationController.js
+++ b/traffic_portal/app/src/common/modules/form/physLocation/FormPhysLocationController.js
@@ -6,9 +6,9 @@
  * to you under the Apache License, Version 2.0 (the
  * "License"); you may not use this file except in compliance
  * with the License.  You may obtain a copy of the License at
- * 
+ *
  *   http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing,
  * software distributed under the License is distributed on an
  * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
@@ -34,7 +34,7 @@ var FormPhysLocationController = function(physLocation, $scope, $location, formU
         { name: 'address', type: 'text', required: true, maxLength: 128 },
         { name: 'city', type: 'text', required: true, maxLength: 128 },
         { name: 'state', type: 'text', required: true, maxLength: 2 },
-        { name: 'zip', type: 'text', required: true, maxLength: 5 },
+        { name: 'zip', type: 'text', required: true, maxLength: 11 },
         { name: 'poc', type: 'text', required: false, maxLength: 128 },
         { name: 'phone', type: 'text', required: false, maxLength: 45 },
         { name: 'email', type: 'email', required: false, maxLength: 128 }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services