You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/03/11 17:41:13 UTC

[GitHub] [solr] lilliehammer opened a new pull request #11: SOLR-15248 Disable login autocomplete

lilliehammer opened a new pull request #11:
URL: https://github.com/apache/solr/pull/11


   # Description
   
   Remove login autocomplete, which currently allows you to see who had previously logged in. 
   
   # Solution
   
   Add `autocomplete=off` 
   
   # Tests
   
   Go to the login page and confirm that clicking in the username box doesn't show other users.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [X] I have created a Jira issue and added the issue ID to my pull request title.
   - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [X] I have developed this patch against the `main` branch.
   - [X] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [solr] janhoy commented on pull request #11: SOLR-15248 Disable login autocomplete

Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #11:
URL: https://github.com/apache/solr/pull/11#issuecomment-796946146


   Have you tested the fix and see it's working?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [solr] lilliehammer commented on pull request #11: SOLR-15248 Disable login autocomplete

Posted by GitBox <gi...@apache.org>.
lilliehammer commented on pull request #11:
URL: https://github.com/apache/solr/pull/11#issuecomment-797662783


   Yes. I also tested it with a password manager (I used LastPass). 
   Before, with password manager
   <img width="1654" alt="SolrBeforeWithManager" src="https://user-images.githubusercontent.com/22902222/110980050-a547b980-8322-11eb-9904-a03f52e911bc.png">
   After, with password manager 
   <img width="1644" alt="SolrAfterWithManager" src="https://user-images.githubusercontent.com/22902222/110980096-b85a8980-8322-11eb-8bdf-79579d0f30e2.png">
   Before, in chrome incognito mode
   <img width="1655" alt="SolrBeforeIncognito" src="https://user-images.githubusercontent.com/22902222/110980123-be506a80-8322-11eb-8f79-92d9569a69fb.png">
   After, in chrome incognito mode
   <img width="1642" alt="SolrAfterIncognito" src="https://user-images.githubusercontent.com/22902222/110980166-cad4c300-8322-11eb-99a8-505edcfeecdc.png">
   
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [solr] janhoy merged pull request #11: SOLR-15248 Disable login autocomplete

Posted by GitBox <gi...@apache.org>.
janhoy merged pull request #11:
URL: https://github.com/apache/solr/pull/11


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [solr] janhoy commented on pull request #11: SOLR-15248 Disable login autocomplete

Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #11:
URL: https://github.com/apache/solr/pull/11#issuecomment-804980979


   Looks good. Will merge and target v9.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org