You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "RoyLee1224 (via GitHub)" <gi...@apache.org> on 2025/06/03 12:04:16 UTC
[PR] Refactor(i18n): Modify filter reset key & update zh-TW files [airflow]
RoyLee1224 opened a new pull request, #51363:
URL: https://github.com/apache/airflow/pull/51363
### Related PRs
#51181
#51242
cc @bbovenzi
This PR includes two main improvements:
### 1. Filter Reset Button Refactor:
**Why:**
To better support the grammatical structures of different languages (e.g., some languages don't require spaces between words, or tend to have verb-final sentence structures).
* **Before:**
```jsx
<LuX /> {translate("table.filters.reset")}{" "}
{filterCount === 1 ? translate("table.filters.filter_one") : translate("table.filters.filter_other")}
```
* **After:**
```jsx
<LuX />{translate("table.filterReset", { count: filterCount })}
```
* **Translation Key Updates:**
* The new translation key `filterReset` has been immediately updated for `de`,`en`,`pl`, and`zh-TW`.
* **Action Required:** Kindly request the respective language Code Owners to review these new translations.
**Screenshots of the corrected UI:**
### 2. `zh-TW` (Traditional Chinese) Translation Updates:
Based on the previous discussion in PR #51242, the Traditional Chinese translations have been updated.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor(i18n): Modify filter reset key & update zh-TW files [airflow]
Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.
RoyLee1224 commented on code in PR #51363:
URL: https://github.com/apache/airflow/pull/51363#discussion_r2126197022
##########
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/dashboard.json:
##########
@@ -3,11 +3,21 @@
"health": {
"dagProcessor": "Dag 處理器",
"health": "健康狀態",
+ "healthy": "健康",
+ "lastHeartbeat": "最後心跳",
"metaDatabase": "系統資料庫",
"scheduler": "排程器",
- "triggerer": "觸發器"
+ "status": "狀態",
+ "triggerer": "觸發器",
+ "unhealthy": "不健康"
Review Comment:
Sure, makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor(i18n): Modify filter reset key & update zh-TW files [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #51363:
URL: https://github.com/apache/airflow/pull/51363#discussion_r2127818600
##########
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/connections.json:
##########
@@ -0,0 +1,4 @@
+{
+ "test": "測試連線",
Review Comment:
nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor(i18n): Modify filter reset key & update zh-TW files [airflow]
Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.
RoyLee1224 commented on code in PR #51363:
URL: https://github.com/apache/airflow/pull/51363#discussion_r2126188081
##########
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/connections.json:
##########
@@ -0,0 +1,4 @@
+{
+ "test": "測試連線",
Review Comment:
It's a verb here, so maybe we can use `測試連線`．
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor(i18n): Modify filter reset key & update zh-TW files [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #51363:
URL: https://github.com/apache/airflow/pull/51363#discussion_r2127954749
##########
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/dags.json:
##########
@@ -0,0 +1,147 @@
+{
+ "assetSchedule": "{{count}} / {{total}} 個資源事件已更新",
+ "dagActions": {
+ "delete": {
+ "button": "刪除 Dag",
+ "warning": "這將會刪除所有與此 Dag 相關的系統資料，包括 Dag 執行與任務。"
+ },
+ "trigger": {
+ "button": "觸發",
+ "triggerDag": "觸發 Dag"
+ }
+ },
+ "filters": {
+ "paused": {
+ "active": "啟用中",
+ "all": "全部",
+ "paused": "暫停"
+ }
+ },
+ "list": {
+ "advancedSearch": "進階搜尋",
+ "clearSearch": "清除搜尋",
+ "columns": {
+ "dagId": "Dag ID",
+ "lastDagRun": "上次 Dag 執行",
+ "nextDagRun": "下次 Dag 執行",
+ "schedule": "排程",
+ "tags": "標籤"
+ },
+ "ownerLink": "擁有者 {{owner}} 的連結",
+ "searchPlaceholder": "搜尋 Dags"
+ },
+ "runAndTaskActions": {
+ "clear": {
+ "button": "清除 {{type}}",
+ "buttonTooltip": "按下 shift+c 清除",
+ "dialog": {
+ "affectedTasks": {
+ "columns": {
+ "mapIndex": "映射索引",
+ "runId": "執行 ID",
+ "state": "狀態",
+ "taskId": "任務 ID"
+ },
+ "noItemsFound": "找不到任務。",
+ "title": "受影響的任務: {{count}}"
+ },
+ "confirm": "確認",
+ "note": {
+ "placeholder": "新增備註...",
+ "title": "備註"
+ },
+ "options": {
+ "downstream": "下游",
+ "existingTasks": "清除現有任務",
+ "future": "未來",
+ "onlyFailed": "清除失敗任務",
+ "past": "過去",
+ "queueNew": "排隊新任務",
+ "upstream": "上游"
+ },
+ "title": "清除{{type}}"
+ }
+ },
+ "delete": {
+ "button": "刪除{{type}}",
+ "dialog": {
+ "resourceName": "{{type}} {{id}}",
+ "title": "刪除{{type}}",
+ "warning": "這將會刪除所有與此{{type}}相關的系統資料。"
+ },
+ "error": "刪除{{type}}時發生錯誤",
+ "success": {
+ "description": "{{type}}刪除請求成功。",
+ "title": "{{type}}刪除成功"
+ }
+ },
+ "markAs": {
+ "button": "標記為{{type}}...",
+ "buttonTooltip": {
+ "failed": "按下 shift+f 標記為失敗",
+ "success": "按下 shift+s 標記為成功"
+ },
+ "dialog": {
+ "confirm": "確認",
+ "options": {
+ "downstream": "下游",
+ "future": "未來",
+ "past": "過去",
+ "upstream": "上游"
+ },
+ "title": "標記為{{type}}為{{state}}"
+ }
+ }
+ },
+ "runs": {
+ "allRunTypes": "全部執行類型",
+ "allStates": "全部狀態",
+ "columns": {
+ "dagId": "Dag ID",
+ "dagVersions": "Dag 版本",
+ "duration": "持續時間",
+ "endDate": "結束日期",
+ "runAfter": "之後執行",
+ "runType": "執行類型",
+ "startDate": "開始日期",
+ "state": "狀態"
+ }
+ },
+ "sort": {
+ "displayName": {
+ "asc": "依顯示名稱排序 (A-Z)",
+ "desc": "依顯示名稱排序 (Z-A)"
+ },
+ "lastRunStartDate": {
+ "asc": "依上次開始執行日期排序 (從新到舊)",
+ "desc": "依上次開始執行日期排序 (從新到舊)"
+ },
+ "lastRunState": {
+ "asc": "依上次執行狀態排序 (A-Z)",
+ "desc": "依上次執行狀態排序 (Z-A)"
+ },
+ "nextDagRun": {
+ "asc": "依下次執行時間排序 (由近而遠)",
+ "desc": "依下次執行時間排序 (由遠而近)"
+ },
+ "placeholder": "排序方式"
+ },
+ "taskInstances": {
+ "allStates": "全部狀態",
+ "columns": {
+ "dagId": "Dag ID",
+ "dagRun": "Dag 執行",
+ "dagVersion": "Dag 版本",
+ "duration": "持續時間",
+ "endDate": "結束日期",
+ "mapIndex": "映射索引",
Review Comment:
https://github.com/apache/airflow/issues/51420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor(i18n): Modify filter reset key & update zh-TW files [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W merged PR #51363:
URL: https://github.com/apache/airflow/pull/51363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor(i18n): Modify filter reset key & update zh-TW files [airflow]
Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.
RoyLee1224 commented on code in PR #51363:
URL: https://github.com/apache/airflow/pull/51363#discussion_r2126188081
##########
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/connections.json:
##########
@@ -0,0 +1,4 @@
+{
+ "test": "測試連線",
Review Comment:
It's a verb here, so maybe we can use `測試連線` and `測試連線功能已停用。請聯繫管理員以啟用`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor(i18n): Modify filter reset key & update zh-TW files [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #51363:
URL: https://github.com/apache/airflow/pull/51363#discussion_r2127819139
##########
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/dags.json:
##########
@@ -0,0 +1,147 @@
+{
+ "assetSchedule": "{{count}} / {{total}} 個資源事件已更新",
+ "dagActions": {
+ "delete": {
+ "button": "刪除 Dag",
+ "warning": "這將會刪除所有與此 Dag 相關的系統資料，包括 Dag 執行與任務。"
+ },
+ "trigger": {
+ "button": "觸發",
+ "triggerDag": "觸發 Dag"
+ }
+ },
+ "filters": {
+ "paused": {
+ "active": "啟用中",
+ "all": "全部",
+ "paused": "暫停"
+ }
+ },
+ "list": {
+ "advancedSearch": "進階搜尋",
+ "clearSearch": "清除搜尋",
+ "columns": {
+ "dagId": "Dag ID",
+ "lastDagRun": "上次 Dag 執行",
+ "nextDagRun": "下次 Dag 執行",
+ "schedule": "排程",
+ "tags": "標籤"
+ },
+ "ownerLink": "擁有者 {{owner}} 的連結",
+ "searchPlaceholder": "搜尋 Dags"
+ },
+ "runAndTaskActions": {
+ "clear": {
+ "button": "清除 {{type}}",
+ "buttonTooltip": "按下 shift+c 清除",
+ "dialog": {
+ "affectedTasks": {
+ "columns": {
+ "mapIndex": "映射索引",
+ "runId": "執行 ID",
+ "state": "狀態",
+ "taskId": "任務 ID"
+ },
+ "noItemsFound": "找不到任務。",
+ "title": "受影響的任務: {{count}}"
+ },
+ "confirm": "確認",
+ "note": {
+ "placeholder": "新增備註...",
+ "title": "備註"
+ },
+ "options": {
+ "downstream": "下游",
+ "existingTasks": "清除現有任務",
+ "future": "未來",
+ "onlyFailed": "清除失敗任務",
+ "past": "過去",
+ "queueNew": "排隊新任務",
+ "upstream": "上游"
+ },
+ "title": "清除{{type}}"
+ }
+ },
+ "delete": {
+ "button": "刪除{{type}}",
+ "dialog": {
+ "resourceName": "{{type}} {{id}}",
+ "title": "刪除{{type}}",
+ "warning": "這將會刪除所有與此{{type}}相關的系統資料。"
+ },
+ "error": "刪除{{type}}時發生錯誤",
+ "success": {
+ "description": "{{type}}刪除請求成功。",
+ "title": "{{type}}刪除成功"
+ }
+ },
+ "markAs": {
+ "button": "標記為{{type}}...",
+ "buttonTooltip": {
+ "failed": "按下 shift+f 標記為失敗",
+ "success": "按下 shift+s 標記為成功"
+ },
+ "dialog": {
+ "confirm": "確認",
+ "options": {
+ "downstream": "下游",
+ "future": "未來",
+ "past": "過去",
+ "upstream": "上游"
+ },
+ "title": "標記為{{type}}為{{state}}"
+ }
+ }
+ },
+ "runs": {
+ "allRunTypes": "全部執行類型",
+ "allStates": "全部狀態",
+ "columns": {
+ "dagId": "Dag ID",
+ "dagVersions": "Dag 版本",
+ "duration": "持續時間",
+ "endDate": "結束日期",
+ "runAfter": "之後執行",
+ "runType": "執行類型",
+ "startDate": "開始日期",
+ "state": "狀態"
+ }
+ },
+ "sort": {
+ "displayName": {
+ "asc": "依顯示名稱排序 (A-Z)",
+ "desc": "依顯示名稱排序 (Z-A)"
+ },
+ "lastRunStartDate": {
+ "asc": "依上次開始執行日期排序 (從新到舊)",
+ "desc": "依上次開始執行日期排序 (從新到舊)"
+ },
+ "lastRunState": {
+ "asc": "依上次執行狀態排序 (A-Z)",
+ "desc": "依上次執行狀態排序 (Z-A)"
+ },
+ "nextDagRun": {
+ "asc": "依下次執行時間排序 (由近而遠)",
+ "desc": "依下次執行時間排序 (由遠而近)"
+ },
+ "placeholder": "排序方式"
+ },
+ "taskInstances": {
+ "allStates": "全部狀態",
+ "columns": {
+ "dagId": "Dag ID",
+ "dagRun": "Dag 執行",
+ "dagVersion": "Dag 版本",
+ "duration": "持續時間",
+ "endDate": "結束日期",
+ "mapIndex": "映射索引",
Review Comment:
Sounds like a good idea. Maybe we can create an issue for tracking this refactoring?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor(i18n): Modify filter reset key & update zh-TW files [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #51363:
URL: https://github.com/apache/airflow/pull/51363#discussion_r2125281219
##########
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/connections.json:
##########
@@ -0,0 +1,4 @@
+{
+ "test": "測試連線",
Review Comment:
```suggestion
"test": "測試用連線",
```
Is it a verb or a noun here? `測試連線` sounds like an action to me, while `測試用連線` sounds more like a noun
##########
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/dashboard.json:
##########
@@ -3,11 +3,21 @@
"health": {
"dagProcessor": "Dag 處理器",
"health": "健康狀態",
+ "healthy": "健康",
+ "lastHeartbeat": "最後心跳",
"metaDatabase": "系統資料庫",
"scheduler": "排程器",
- "triggerer": "觸發器"
+ "status": "狀態",
+ "triggerer": "觸發器",
+ "unhealthy": "不健康"
Review Comment:
I get the point of this but ...
how about
```suggestion
"unhealthy": "健康狀態異常"
```
?
##########
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/dags.json:
##########
@@ -0,0 +1,147 @@
+{
+ "assetSchedule": "{{count}} / {{total}} 個資源事件已更新",
+ "dagActions": {
+ "delete": {
+ "button": "刪除 Dag",
+ "warning": "這將會刪除所有與此 Dag 相關的系統資料，包括 Dag 執行與任務。"
+ },
+ "trigger": {
+ "button": "觸發",
+ "triggerDag": "觸發 Dag"
+ }
+ },
+ "filters": {
+ "paused": {
+ "active": "啟用中",
+ "all": "全部",
+ "paused": "暫停"
+ }
+ },
+ "list": {
+ "advancedSearch": "進階搜尋",
+ "clearSearch": "清除搜尋",
+ "columns": {
+ "dagId": "Dag ID",
+ "lastDagRun": "上次 Dag 執行",
+ "nextDagRun": "下次 Dag 執行",
+ "schedule": "排程",
+ "tags": "標籤"
+ },
+ "ownerLink": "擁有者 {{owner}} 的連結",
+ "searchPlaceholder": "搜尋 Dags"
+ },
+ "runAndTaskActions": {
+ "clear": {
+ "button": "清除 {{type}}",
+ "buttonTooltip": "按下 shift+c 清除",
+ "dialog": {
+ "affectedTasks": {
+ "columns": {
+ "mapIndex": "映射索引",
+ "runId": "執行 ID",
+ "state": "狀態",
+ "taskId": "任務 ID"
+ },
+ "noItemsFound": "找不到任務。",
+ "title": "受影響的任務: {{count}}"
+ },
+ "confirm": "確認",
+ "note": {
+ "placeholder": "新增備註...",
+ "title": "備註"
+ },
+ "options": {
+ "downstream": "下游",
+ "existingTasks": "清除現有任務",
+ "future": "未來",
+ "onlyFailed": "清除失敗任務",
+ "past": "過去",
+ "queueNew": "排隊新任務",
+ "upstream": "上游"
+ },
+ "title": "清除{{type}}"
+ }
+ },
+ "delete": {
+ "button": "刪除{{type}}",
+ "dialog": {
+ "resourceName": "{{type}} {{id}}",
+ "title": "刪除{{type}}",
+ "warning": "這將會刪除所有與此{{type}}相關的系統資料。"
+ },
+ "error": "刪除{{type}}時發生錯誤",
+ "success": {
+ "description": "{{type}}刪除請求成功。",
+ "title": "{{type}}刪除成功"
+ }
+ },
+ "markAs": {
+ "button": "標記為{{type}}...",
+ "buttonTooltip": {
+ "failed": "按下 shift+f 標記為失敗",
+ "success": "按下 shift+s 標記為成功"
+ },
+ "dialog": {
+ "confirm": "確認",
+ "options": {
+ "downstream": "下游",
+ "future": "未來",
+ "past": "過去",
+ "upstream": "上游"
+ },
+ "title": "標記為{{type}}為{{state}}"
+ }
+ }
+ },
+ "runs": {
+ "allRunTypes": "全部執行類型",
+ "allStates": "全部狀態",
+ "columns": {
+ "dagId": "Dag ID",
+ "dagVersions": "Dag 版本",
+ "duration": "持續時間",
+ "endDate": "結束日期",
+ "runAfter": "之後執行",
+ "runType": "執行類型",
+ "startDate": "開始日期",
+ "state": "狀態"
+ }
+ },
+ "sort": {
+ "displayName": {
+ "asc": "依顯示名稱排序 (A-Z)",
+ "desc": "依顯示名稱排序 (Z-A)"
+ },
+ "lastRunStartDate": {
+ "asc": "依上次開始執行日期排序 (從新到舊)",
+ "desc": "依上次開始執行日期排序 (從新到舊)"
+ },
+ "lastRunState": {
+ "asc": "依上次執行狀態排序 (A-Z)",
+ "desc": "依上次執行狀態排序 (Z-A)"
+ },
+ "nextDagRun": {
+ "asc": "依下次執行時間排序 (由近而遠)",
+ "desc": "依下次執行時間排序 (由遠而近)"
+ },
+ "placeholder": "排序方式"
+ },
+ "taskInstances": {
+ "allStates": "全部狀態",
+ "columns": {
+ "dagId": "Dag ID",
+ "dagRun": "Dag 執行",
+ "dagVersion": "Dag 版本",
+ "duration": "持續時間",
+ "endDate": "結束日期",
+ "mapIndex": "映射索引",
Review Comment:
This comment is unlikely to be addressed in this pull request. However, I'm considering creating something similar to https://github.com/python/python-docs-zh-tw/wiki/%E8%A1%93%E8%AA%9E%E5%88%97%E8%A1%A8 and referencing these terms there somehow.
Not sure whether it's worth it. The pro is to reduce the chance of term diverge, the con is more complicate structure needed (something jinja like might be needed and I'm a bit worried about introducing something like it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor(i18n): Modify filter reset key & update zh-TW files [airflow]
Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.
RoyLee1224 commented on code in PR #51363:
URL: https://github.com/apache/airflow/pull/51363#discussion_r2126188081
##########
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/connections.json:
##########
@@ -0,0 +1,4 @@
+{
+ "test": "測試連線",
Review Comment:
It's a verb here, so maybe we can use `測試連線` and `測試連線功能已停用...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor(i18n): Modify filter reset key & update zh-TW files [airflow]
Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.
RoyLee1224 commented on code in PR #51363:
URL: https://github.com/apache/airflow/pull/51363#discussion_r2127554732
##########
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/dags.json:
##########
@@ -0,0 +1,147 @@
+{
+ "assetSchedule": "{{count}} / {{total}} 個資源事件已更新",
+ "dagActions": {
+ "delete": {
+ "button": "刪除 Dag",
+ "warning": "這將會刪除所有與此 Dag 相關的系統資料，包括 Dag 執行與任務。"
+ },
+ "trigger": {
+ "button": "觸發",
+ "triggerDag": "觸發 Dag"
+ }
+ },
+ "filters": {
+ "paused": {
+ "active": "啟用中",
+ "all": "全部",
+ "paused": "暫停"
+ }
+ },
+ "list": {
+ "advancedSearch": "進階搜尋",
+ "clearSearch": "清除搜尋",
+ "columns": {
+ "dagId": "Dag ID",
+ "lastDagRun": "上次 Dag 執行",
+ "nextDagRun": "下次 Dag 執行",
+ "schedule": "排程",
+ "tags": "標籤"
+ },
+ "ownerLink": "擁有者 {{owner}} 的連結",
+ "searchPlaceholder": "搜尋 Dags"
+ },
+ "runAndTaskActions": {
+ "clear": {
+ "button": "清除 {{type}}",
+ "buttonTooltip": "按下 shift+c 清除",
+ "dialog": {
+ "affectedTasks": {
+ "columns": {
+ "mapIndex": "映射索引",
+ "runId": "執行 ID",
+ "state": "狀態",
+ "taskId": "任務 ID"
+ },
+ "noItemsFound": "找不到任務。",
+ "title": "受影響的任務: {{count}}"
+ },
+ "confirm": "確認",
+ "note": {
+ "placeholder": "新增備註...",
+ "title": "備註"
+ },
+ "options": {
+ "downstream": "下游",
+ "existingTasks": "清除現有任務",
+ "future": "未來",
+ "onlyFailed": "清除失敗任務",
+ "past": "過去",
+ "queueNew": "排隊新任務",
+ "upstream": "上游"
+ },
+ "title": "清除{{type}}"
+ }
+ },
+ "delete": {
+ "button": "刪除{{type}}",
+ "dialog": {
+ "resourceName": "{{type}} {{id}}",
+ "title": "刪除{{type}}",
+ "warning": "這將會刪除所有與此{{type}}相關的系統資料。"
+ },
+ "error": "刪除{{type}}時發生錯誤",
+ "success": {
+ "description": "{{type}}刪除請求成功。",
+ "title": "{{type}}刪除成功"
+ }
+ },
+ "markAs": {
+ "button": "標記為{{type}}...",
+ "buttonTooltip": {
+ "failed": "按下 shift+f 標記為失敗",
+ "success": "按下 shift+s 標記為成功"
+ },
+ "dialog": {
+ "confirm": "確認",
+ "options": {
+ "downstream": "下游",
+ "future": "未來",
+ "past": "過去",
+ "upstream": "上游"
+ },
+ "title": "標記為{{type}}為{{state}}"
+ }
+ }
+ },
+ "runs": {
+ "allRunTypes": "全部執行類型",
+ "allStates": "全部狀態",
+ "columns": {
+ "dagId": "Dag ID",
+ "dagVersions": "Dag 版本",
+ "duration": "持續時間",
+ "endDate": "結束日期",
+ "runAfter": "之後執行",
+ "runType": "執行類型",
+ "startDate": "開始日期",
+ "state": "狀態"
+ }
+ },
+ "sort": {
+ "displayName": {
+ "asc": "依顯示名稱排序 (A-Z)",
+ "desc": "依顯示名稱排序 (Z-A)"
+ },
+ "lastRunStartDate": {
+ "asc": "依上次開始執行日期排序 (從新到舊)",
+ "desc": "依上次開始執行日期排序 (從新到舊)"
+ },
+ "lastRunState": {
+ "asc": "依上次執行狀態排序 (A-Z)",
+ "desc": "依上次執行狀態排序 (Z-A)"
+ },
+ "nextDagRun": {
+ "asc": "依下次執行時間排序 (由近而遠)",
+ "desc": "依下次執行時間排序 (由遠而近)"
+ },
+ "placeholder": "排序方式"
+ },
+ "taskInstances": {
+ "allStates": "全部狀態",
+ "columns": {
+ "dagId": "Dag ID",
+ "dagRun": "Dag 執行",
+ "dagVersion": "Dag 版本",
+ "duration": "持續時間",
+ "endDate": "結束日期",
+ "mapIndex": "映射索引",
Review Comment:
As an initial step, perhaps we could create a Markdown-formatted glossary in airflow/docs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor(i18n): Modify filter reset key & update zh-TW files [airflow]
Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.
RoyLee1224 commented on code in PR #51363:
URL: https://github.com/apache/airflow/pull/51363#discussion_r2126188081
##########
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/connections.json:
##########
@@ -0,0 +1,4 @@
+{
+ "test": "測試連線",
Review Comment:
It's a verb here, so maybe we can use `測試連線` and `測試連線功能已停用。請聯繫管理員已啟用`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor(i18n): Modify filter reset key & update zh-TW files [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #51363:
URL: https://github.com/apache/airflow/pull/51363#discussion_r2125314514
##########
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/dags.json:
##########
@@ -0,0 +1,147 @@
+{
+ "assetSchedule": "{{count}} / {{total}} 個資源事件已更新",
+ "dagActions": {
+ "delete": {
+ "button": "刪除 Dag",
+ "warning": "這將會刪除所有與此 Dag 相關的系統資料，包括 Dag 執行與任務。"
+ },
+ "trigger": {
+ "button": "觸發",
+ "triggerDag": "觸發 Dag"
+ }
+ },
+ "filters": {
+ "paused": {
+ "active": "啟用中",
+ "all": "全部",
+ "paused": "暫停"
+ }
+ },
+ "list": {
+ "advancedSearch": "進階搜尋",
+ "clearSearch": "清除搜尋",
+ "columns": {
+ "dagId": "Dag ID",
+ "lastDagRun": "上次 Dag 執行",
+ "nextDagRun": "下次 Dag 執行",
+ "schedule": "排程",
+ "tags": "標籤"
+ },
+ "ownerLink": "擁有者 {{owner}} 的連結",
+ "searchPlaceholder": "搜尋 Dags"
+ },
+ "runAndTaskActions": {
+ "clear": {
+ "button": "清除 {{type}}",
+ "buttonTooltip": "按下 shift+c 清除",
+ "dialog": {
+ "affectedTasks": {
+ "columns": {
+ "mapIndex": "映射索引",
+ "runId": "執行 ID",
+ "state": "狀態",
+ "taskId": "任務 ID"
+ },
+ "noItemsFound": "找不到任務。",
+ "title": "受影響的任務: {{count}}"
+ },
+ "confirm": "確認",
+ "note": {
+ "placeholder": "新增備註...",
+ "title": "備註"
+ },
+ "options": {
+ "downstream": "下游",
+ "existingTasks": "清除現有任務",
+ "future": "未來",
+ "onlyFailed": "清除失敗任務",
+ "past": "過去",
+ "queueNew": "排隊新任務",
+ "upstream": "上游"
+ },
+ "title": "清除{{type}}"
+ }
+ },
+ "delete": {
+ "button": "刪除{{type}}",
+ "dialog": {
+ "resourceName": "{{type}} {{id}}",
+ "title": "刪除{{type}}",
+ "warning": "這將會刪除所有與此{{type}}相關的系統資料。"
+ },
+ "error": "刪除{{type}}時發生錯誤",
+ "success": {
+ "description": "{{type}}刪除請求成功。",
+ "title": "{{type}}刪除成功"
+ }
+ },
+ "markAs": {
+ "button": "標記為{{type}}...",
+ "buttonTooltip": {
+ "failed": "按下 shift+f 標記為失敗",
+ "success": "按下 shift+s 標記為成功"
+ },
+ "dialog": {
+ "confirm": "確認",
+ "options": {
+ "downstream": "下游",
+ "future": "未來",
+ "past": "過去",
+ "upstream": "上游"
+ },
+ "title": "標記為{{type}}為{{state}}"
+ }
+ }
+ },
+ "runs": {
+ "allRunTypes": "全部執行類型",
+ "allStates": "全部狀態",
+ "columns": {
+ "dagId": "Dag ID",
+ "dagVersions": "Dag 版本",
+ "duration": "持續時間",
+ "endDate": "結束日期",
+ "runAfter": "之後執行",
+ "runType": "執行類型",
+ "startDate": "開始日期",
+ "state": "狀態"
+ }
+ },
+ "sort": {
+ "displayName": {
+ "asc": "依顯示名稱排序 (A-Z)",
+ "desc": "依顯示名稱排序 (Z-A)"
+ },
+ "lastRunStartDate": {
+ "asc": "依上次開始執行日期排序 (從新到舊)",
+ "desc": "依上次開始執行日期排序 (從新到舊)"
+ },
+ "lastRunState": {
+ "asc": "依上次執行狀態排序 (A-Z)",
+ "desc": "依上次執行狀態排序 (Z-A)"
+ },
+ "nextDagRun": {
+ "asc": "依下次執行時間排序 (由近而遠)",
+ "desc": "依下次執行時間排序 (由遠而近)"
+ },
+ "placeholder": "排序方式"
+ },
+ "taskInstances": {
+ "allStates": "全部狀態",
+ "columns": {
+ "dagId": "Dag ID",
+ "dagRun": "Dag 執行",
+ "dagVersion": "Dag 版本",
+ "duration": "持續時間",
+ "endDate": "結束日期",
+ "mapIndex": "映射索引",
Review Comment:
This comment doesn't need to be addressed in this pull request. However, I'm considering creating something similar to https://github.com/python/python-docs-zh-tw/wiki/%E8%A1%93%E8%AA%9E%E5%88%97%E8%A1%A8 and referencing these terms there somehow.
Not sure whether it's worth it. The pro is to reduce the chance of term diverge, the con is more complicate structure needed (something jinja like might be needed and I'm a bit worried about introducing something like it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor(i18n): Modify filter reset key & update zh-TW files [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #51363:
URL: https://github.com/apache/airflow/pull/51363#discussion_r2125316428
##########
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/connections.json:
##########
@@ -0,0 +1,4 @@
+{
+ "test": "測試連線",
Review Comment:
Also related to it (not to be addressed in this PR), not sure whether we have a smart way to automatically screenshot all relevant pages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org