You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2014/10/23 12:44:39 UTC

Review Request 27072: Broken Dashboard after routing to Views

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27072/
-----------------------------------------------------------

Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.


Bugs: AMBARI-7852
    https://issues.apache.org/jira/browse/AMBARI-7852


Repository: ambari


Description
-------

STR:
1. Start Cluster Installer
2. Proceed to "Summary" step
3. Click on Views icon
Result: Top menu is visible, but tabs' content is corrupted; No link back to Installer to complete installation.
Expected:
Top menu should be hidden, Manage Ambari should have link to installer until it's finished.


Diffs
-----

  ambari-web/app/assets/test/tests.js 65082ab 
  ambari-web/app/views/main/menu.js 69d0e45 
  ambari-web/test/views/main/menu_test.js PRE-CREATION 

Diff: https://reviews.apache.org/r/27072/diff/


Testing
-------

4696 tests complete (9 seconds)
  60 tests pending


Thanks,

Andrii Tkach


Re: Review Request 27072: Broken Dashboard after routing to Views

Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27072/#review57973
-----------------------------------------------------------

Ship it!


Ship It!

- Oleg Nechiporenko


On Oct. 23, 2014, 10:44 a.m., Andrii Tkach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27072/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2014, 10:44 a.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-7852
>     https://issues.apache.org/jira/browse/AMBARI-7852
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR:
> 1. Start Cluster Installer
> 2. Proceed to "Summary" step
> 3. Click on Views icon
> Result: Top menu is visible, but tabs' content is corrupted; No link back to Installer to complete installation.
> Expected:
> Top menu should be hidden, Manage Ambari should have link to installer until it's finished.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/test/tests.js 65082ab 
>   ambari-web/app/views/main/menu.js 69d0e45 
>   ambari-web/test/views/main/menu_test.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27072/diff/
> 
> 
> Testing
> -------
> 
> 4696 tests complete (9 seconds)
>   60 tests pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>


Re: Review Request 27072: Broken Dashboard after routing to Views

Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27072/#review57974
-----------------------------------------------------------

Ship it!


Ship It!

- Aleksandr Kovalenko


On Жов. 23, 2014, 10:44 до полудня, Andrii Tkach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27072/
> -----------------------------------------------------------
> 
> (Updated Жов. 23, 2014, 10:44 до полудня)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-7852
>     https://issues.apache.org/jira/browse/AMBARI-7852
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR:
> 1. Start Cluster Installer
> 2. Proceed to "Summary" step
> 3. Click on Views icon
> Result: Top menu is visible, but tabs' content is corrupted; No link back to Installer to complete installation.
> Expected:
> Top menu should be hidden, Manage Ambari should have link to installer until it's finished.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/test/tests.js 65082ab 
>   ambari-web/app/views/main/menu.js 69d0e45 
>   ambari-web/test/views/main/menu_test.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27072/diff/
> 
> 
> Testing
> -------
> 
> 4696 tests complete (9 seconds)
>   60 tests pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>