You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/08 15:48:31 UTC
[GitHub] [pulsar] nicoloboschi opened a new pull request, #17552: [ci] Move more tests to the flaky suite
nicoloboschi opened a new pull request, #17552:
URL: https://github.com/apache/pulsar/pull/17552
### Motivation
Based on these reports, move the most flaky tests to the flaky suite to avoid blocking pulls to being merged
[Source](https://github.com/lhotari/pulsar-test-reporting)
```
"org.apache.pulsar.broker.service.persistent.PersistentDispatcherFailoverConsumerStreamingDispatcherTest.testAddRemoveConsumer": 27,
"org.apache.pulsar.tests.integration.functions.java.PulsarFunctionsJavaThreadTest.testJavaLoggingFunction": 13,
"org.apache.pulsar.broker.service.persistent.PersistentSubscriptionMessageDispatchStreamingDispatcherThrottlingTest.testMultiLevelDispatch": 11,
"org.apache.pulsar.client.api.ClientDeduplicationFailureTest.testClientDeduplicationWithBkFailure": 11,
"org.apache.pulsar.client.impl.RawReaderTest.testFlowControlBatch": 10,
"org.apache.pulsar.client.api.v1.V1_ProducerConsumerTest.testActiveAndInActiveConsumerEntryCacheBehavior": 8,
"org.apache.pulsar.broker.service.persistent.PersistentStreamingDispatcherBlockConsumerTest.testBrokerSubscriptionRecovery": 7,
"org.apache.pulsar.functions.worker.PulsarFunctionTlsTest.tearDown": 3,
"org.apache.pulsar.tests.integration.io.sources.debezium.PulsarDebeziumOracleSourceTest.testDebeziumOracleDbSource": 3,
"org.apache.pulsar.broker.service.persistent.SimpleProducerConsumerTestStreamingDispatcherTest.testMultiTopicsConsumerImplPauseForManualSubscription": 2,
"org.apache.pulsar.broker.service.ServerCnxTest.testHandleAuthResponseWithoutClientVersion": 2,
"org.apache.pulsar.broker.service.persistent.PersistentSubscriptionMessageDispatchStreamingDispatcherThrottlingTest.testBytesRateLimitingReceiveAllMessagesAfterThrottling": 2,
"org.apache.pulsar.broker.namespace.NamespaceServiceTest.testSplitBundleWithHighestThroughput": 2,
"org.apache.pulsar.io.jdbc.SqliteJdbcSinkTest.tearDown": 2,
```
[Source](https://github.com/nicoloboschi/pulsar-validation-tool/blob/master/pulsar-scripts/pulsar-gha/download-failed-tests.js)
```
"PersistentStreamingDispatcherBlockConsumerTest.testBrokerSubscriptionRecovery": 132,
"V1_ProducerConsumerTest.testActiveAndInActiveConsumerEntryCacheBehavior": 78,
"PulsarDebeziumOracleSourceTest.testDebeziumOracleDbSource": 23,
"OffloadPrefixTest.autoTriggerWhileManualInProgress": 3,
"PersistentDispatcherFailoverConsumerStreamingDispatcherTest.testAddRemoveConsumer": 110,
"PersistentSubscriptionMessageDispatchStreamingDispatcherThrottlingTest.testBytesRateLimitingReceiveAllMessagesAfterThrottling": 5,
"KinesisSinkTest.testWrite": 2,
"PersistentSubscriptionMessageDispatchStreamingDispatcherThrottlingTest.testMultiLevelDispatch": 37,
"PersistentTopicsTest.testUpdatePartitionedTopicHavingProperties": 2,
"OffloadPrefixTest.testOffloadThreeFirstFails": 4,
"ZKSessionTest.testSessionLost": 22,
"ResourceGroupUsageAggregationTest.testProduceConsumeUsageOnRG": 11,
"TopicReaderTest.testMultiReaderIsAbleToSeekWithTimeOnMiddleOfTopic": 6,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #17552: [ci] Move more tests to the flaky suite
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17552:
URL: https://github.com/apache/pulsar/pull/17552#issuecomment-1241869776
@nicoloboschi Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #17552: [ci] Move more tests to the flaky suite
Posted by GitBox <gi...@apache.org>.
lhotari merged PR #17552:
URL: https://github.com/apache/pulsar/pull/17552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a diff in pull request #17552: [ci] Move more tests to the flaky suite
Posted by GitBox <gi...@apache.org>.
lhotari commented on code in PR #17552:
URL: https://github.com/apache/pulsar/pull/17552#discussion_r966146093
##########
pulsar-io/jdbc/sqlite/src/test/java/org/apache/pulsar/io/jdbc/SqliteJdbcSinkTest.java:
##########
@@ -63,6 +63,7 @@
* Jdbc Sink test
*/
@Slf4j
+@Test(groups = "flaky")
Review Comment:
I wonder if pulsar-io has proper handling for flaky tests. I think flaky group is currently handled only for pulsar-broker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a diff in pull request #17552: [ci] Move more tests to the flaky suite
Posted by GitBox <gi...@apache.org>.
lhotari commented on code in PR #17552:
URL: https://github.com/apache/pulsar/pull/17552#discussion_r966146347
##########
pulsar-io/jdbc/sqlite/src/test/java/org/apache/pulsar/io/jdbc/SqliteJdbcSinkTest.java:
##########
@@ -63,6 +63,7 @@
* Jdbc Sink test
*/
@Slf4j
+@Test(groups = "flaky")
Review Comment:
It's better to omit this change for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a diff in pull request #17552: [ci] Move more tests to the flaky suite
Posted by GitBox <gi...@apache.org>.
lhotari commented on code in PR #17552:
URL: https://github.com/apache/pulsar/pull/17552#discussion_r966146859
##########
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/OffloadPrefixTest.java:
##########
@@ -52,6 +52,7 @@
import org.slf4j.LoggerFactory;
import org.testng.annotations.Test;
+@Test(groups = "flaky")
Review Comment:
I wonder if managed-ledger has proper handling for flaky tests. I think flaky group is currently handled only for pulsar-broker. It might be better to omit this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org