You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2015/08/15 01:25:15 UTC

Review Request 37493: Detect gflags when present and link when building Python module

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37493/
-----------------------------------------------------------

Review request for mesos, Joris Van Remoortere and Till Toenshoff.


Bugs: MESOS-1010
    https://issues.apache.org/jira/browse/MESOS-1010


Repository: mesos


Description
-------

Detect gflags when present and link when building Python module


Diffs
-----

  configure.ac a478ebd331ff2eed25ced2d86d9e6bda3376e2ab 

Diff: https://reviews.apache.org/r/37493/diff/


Testing
-------

Did the following:

../configure && make && make check

For each of these cases:
1. using bundled glog, with gflags not installed
2. using bundled glog, with gflags installed
3. using system glog (built without gflags) via --with-glog=..., with gflags not installed
4. using system glog (built without gflags) via --with-glog=..., with gflags installed
5. using system glog (built with gflags) via --with-glog=..., with gflags installed

Test suite passes in all cases.


Thanks,

Greg Mann