[jira] [Commented] (THRIFT-3560) C++ TTransport::isOpen() and TTransport::getOrigin() should be const member functions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218723#comment-16218723 ] 

ASF GitHub Bot commented on THRIFT-3560:
----------------------------------------

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/798
  
    We need to decide if we move forward with this or not.  I'm in favor of const correctness here however it is one of those things you need to do from the beginning because it changes the ABI.  We have a prettu good test suite for this project and I think the only possible issue is that user's subclasses of these bases might no longer override what they expect to override.  As with all breaking changes however it would be documented in the readme for lib/cpp.


> C++ TTransport::isOpen() and TTransport::getOrigin() should be const member functions
> -------------------------------------------------------------------------------------
>
>                 Key: THRIFT-3560
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3560
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>    Affects Versions: 0.9.3, 0.10.0, 1.0
>            Reporter: Sebastian Zenker
>            Priority: Minor
>              Labels: easyfix
>
> ... as they should not alter the state of TTransport. Also peek() should be const in my opinion, but this requires some more refactoring.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)