You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/12/03 02:28:08 UTC
[GitHub] [geode] Bill opened a new pull request #7161: add ability to turn off buffer pooling
Bill opened a new pull request #7161:
URL: https://github.com/apache/geode/pull/7161
Working on a P2P messaging bug. Adding ability to turn off pooling of `ByteBuffer`s by setting new system property: `-Dgeode.byte.buffer.pool.strategy=none`
- [ ] figure out how to pass along system property from test invocation to DUnit VM invocations in `P2PMessagingConcurrencyDUnitTest`
- [ ] run `P2PMessagingConcurrencyDUnitTest` with `-Dgeode.byte.buffer.pool.strategy=none` and verify the no-op `BufferPoolNoOp` is used (and the test passes)
<!-- Thank you for submitting a contribution to Apache Geode. -->
<!-- In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
-->
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
<!-- Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] Bill commented on pull request #7161: add ability to turn off buffer pooling
Posted by GitBox <gi...@apache.org>.
Bill commented on pull request #7161:
URL: https://github.com/apache/geode/pull/7161#issuecomment-988263453
Had a failure in upgrade test: https://concourse.apachegeode-ci.info/builds/6265749
re-triggered…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on pull request #7161: add ability to turn off buffer pooling
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on pull request #7161:
URL: https://github.com/apache/geode/pull/7161#issuecomment-1030572871
this PR appears to be abandoned, can it be closed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org