[GitHub] [pinot] siddharthteotia commented on a change in pull request #8140: Allocation free `DataBlockCache` lookups

[GitBox <gi...@apache.org>]

siddharthteotia commented on a change in pull request #8140:
URL: https://github.com/apache/pinot/pull/8140#discussion_r800104730



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/common/DataBlockCache.java
##########
@@ -109,12 +111,11 @@ public int getNumDocs() {
    * @return Array of int values
    */
   public int[] getIntValuesForSVColumn(String column) {
-    ColumnTypePair key = new ColumnTypePair(column, FieldSpec.DataType.INT);

Review comment:
       So the potential problem being fixed here is the per call creation of `ColumnTypePair` object and that is leading to some heap/perf overhead ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org