You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/29 20:21:14 UTC

[GitHub] [incubator-superset] michellethomas opened a new pull request #7410: Setting renderTrigger on label_colors

michellethomas opened a new pull request #7410: Setting renderTrigger on label_colors
URL: https://github.com/apache/incubator-superset/pull/7410
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   The "Chart Options" section is showing up under the data tab which looks confusing because it contains controls for the color, legend (things that don't affect the data). The section is moved to the data tab if any of the controls don't have renderTrigger true, so if label_colors is set to `renderTrigger` the "Chart Options" goes back to the Visual tab. 
   
   ### TEST PLAN
   Go to explore, verify "Chart options" is under the "Visual Properties" tab
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: Fixes #7393
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @graceguo-supercat @khtruong 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org