You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/06/15 16:43:13 UTC

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3881: risc-v/esp32c3: Support ESP32-C3 efuse

gustavonihei commented on a change in pull request #3881:
URL: https://github.com/apache/incubator-nuttx/pull/3881#discussion_r651969572



##########
File path: arch/risc-v/src/esp32c3/esp32c3_efuse_lowerhalf.c
##########
@@ -0,0 +1,243 @@
+/****************************************************************************
+ * arch/risc-v/src/esp32c3/esp32c3_efuse_lowerhalf.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.  The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <stdlib.h>
+#include <debug.h>
+#include <assert.h>
+#include <nuttx/kmalloc.h>
+#include <nuttx/efuse/efuse.h>
+
+#include "hardware/esp32c3_soc.h"
+#include "esp32c3_efuse.h"
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+struct esp32c3_efuse_lowerhalf_s
+{
+  FAR const struct efuse_ops_s *ops; /* Lower half operations */
+  void *upper;                       /* Pointer to efuse_upperhalf_s */
+};
+
+/****************************************************************************
+ * Private Functions Prototypes
+ ****************************************************************************/
+
+/* "Lower half" driver methods */
+
+static int esp32c3_efuse_lowerhalf_read(FAR struct efuse_lowerhalf_s *lower,
+                                        const efuse_desc_t *field[],
+                                        uint8_t *data, size_t bits_len);
+static int esp32c3_efuse_lowerhalf_write(FAR struct efuse_lowerhalf_s *lower,
+                                         const efuse_desc_t *field[],
+                                         const uint8_t *data,
+                                         size_t bits_len);
+static int esp32c3_efuse_lowerhalf_ioctl(FAR struct efuse_lowerhalf_s *lower,
+                                         int cmd, unsigned long arg);
+
+/****************************************************************************
+ * Private Data
+ ****************************************************************************/
+
+/* "Lower half" driver methods */
+
+static const struct efuse_ops_s g_esp32c3_efuse_ops =
+{
+  .read_field   = esp32c3_efuse_lowerhalf_read,
+  .write_field  = esp32c3_efuse_lowerhalf_write,
+  .ioctl        = esp32c3_efuse_lowerhalf_ioctl,
+};
+
+/* EFUSE lower-half */
+
+static struct esp32c3_efuse_lowerhalf_s g_esp32c3_efuse_lowerhalf =
+{
+  .ops = &g_esp32c3_efuse_ops,
+  .upper = NULL,
+};
+
+/****************************************************************************
+ * Private functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: esp32c3_efuse_lowerhalf_read;
+ *
+ * Description:
+ *   Read value from EFUSE, writing it into an array.
+ *
+ * Input Parameters:
+ *   lower          - A pointer the publicly visible representation of
+ *                    the "lower-half" driver state structure
+ *   field          - A pointer to describing the fields of efuse
+ *   dst            - A pointer to array that contains the data for reading
+ *   bits_len       - The number of bits required to read
+ *
+ * Returned Value:
+ *   Zero (OK) is returned on success. Otherwise -1 (ERROR).
+ *
+ ****************************************************************************/
+
+static int esp32c3_efuse_lowerhalf_read(FAR struct efuse_lowerhalf_s *lower,
+                                        const efuse_desc_t *field[],
+                                        uint8_t *data, size_t bits_len)
+{
+  int ret = OK;
+
+  /* Read the requested field */
+
+  ret = esp32c3_efuse_read_field(field, data, bits_len);
+
+  return ret;
+}
+
+/****************************************************************************
+ * Name: esp32c3_efuse_lowerhalf_write;
+ *
+ * Description:
+ *   Write array to EFUSE.
+ *
+ * Input Parameters:
+ *   lower          - A pointer the publicly visible representation of
+ *                    the "lower-half" driver state structure
+ *   field          - A pointer to describing the fields of efuse
+ *   data           - A pointer to array that contains the data for writing
+ *   bits_len       - The number of bits required to write
+ *
+ * Returned Value:
+ *   Zero (OK) is returned on success. Otherwise -1 (ERROR).
+ *
+ ****************************************************************************/
+
+static int esp32c3_efuse_lowerhalf_write(FAR struct efuse_lowerhalf_s *lower,
+                                         const efuse_desc_t *field[],
+                                         const uint8_t *data,
+                                         size_t bits_len)
+{
+  irqstate_t flags;
+  int ret = OK;
+
+  flags = enter_critical_section();
+
+  /* Write the blob data to the field */
+
+  ret = esp32c3_efuse_write_field(field, data, bits_len);
+
+  /* Burn the EFUSEs */
+
+  esp32c3_efuse_burn_efuses();
+
+  leave_critical_section(flags);
+
+  return ret;
+}
+
+/****************************************************************************
+ * Name: esp32c3_efuse_lowerhalf_ioctl;
+ *
+ * Description:
+ *   Initialize the efuse driver. The efuse is initialized
+ *   and registered as 'devpath'.
+ *
+ * Input Parameters:
+ *   lower        - A pointer the publicly visible representation of
+ *                  the "lower-half" driver state structure
+ *   cmd          - The ioctol command value
+ *   arg          - The optional argument that accompanies the 'cmd'
+ *
+ * Returned Value:
+ *   Zero (OK) is returned on success. Otherwise -1 (ERROR).
+ *
+ ****************************************************************************/
+
+static int esp32c3_efuse_lowerhalf_ioctl(FAR struct efuse_lowerhalf_s *lower,
+                                         int cmd, unsigned long arg)
+{
+  int ret = OK;
+
+  switch (cmd)
+    {
+      /* We don't have proprietary EFUSE ioctls */
+
+      default:
+        {
+          minfo("Unrecognized cmd: %d\n", cmd);
+          ret = -ENOTTY;
+        }
+        break;
+    }
+
+  return ret;
+}
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: esp32c3_efuse_initialize;
+ *
+ * Description:
+ *   Initialize the efuse driver. The efuse is initialized
+ *   and registered as 'devpath'.
+ *
+ * Input Parameters:
+ *   devpath        - The full path to the efuse device.
+ *                    This should be of the form /dev/efuse
+ *
+ * Returned Value:
+ *   Zero (OK) is returned on success. Otherwise -1 (ERROR).
+ *
+ ****************************************************************************/
+
+int esp32c3_efuse_initialize(FAR const char *devpath)
+{
+  struct esp32c3_efuse_lowerhalf_s *lower = NULL;
+  int ret = OK;
+
+  DEBUGASSERT(devpath != NULL);
+
+  lower = &g_esp32c3_efuse_lowerhalf;
+
+  /* Register the efuse upper driver */
+
+  lower->upper = efuse_register(devpath,
+                                (FAR struct efuse_lowerhalf_s *)lower);
+
+  if (lower->upper == NULL)
+    {
+      /* The actual cause of the failure may have been a failure to allocate
+       * perhaps a failure to register the efuser driver (such as if the
+       * 'devpath' were not unique).  We know here but we return EEXIST to
+       * indicate the failure (implying the non-unique devpath).
+       */
+
+      ret = -EEXIST;
+      goto errout;
+    }
+
+errout:
+  return ret;

Review comment:
       ```suggestion
       }
   
     return ret;
   ```
   No need for this `goto`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org