[jira] Commented: (HARMONY-3126) [drlvm] VMMagic: migration to new interfaces

["Alexey Varlamov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HARMONY-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471221 ] 

Alexey Varlamov commented on HARMONY-3126:
------------------------------------------

Mikhail, I noticed the following issues:
1) Seems that newly exported function "field_is_magic_type_reference()" has no direct use. The only current usecase is (and I could not invent any other): 
-            if (field_is_reference(fh)) {
+            if (field_is_reference(fh) && !field_is_magic_type_reference(fh)) {
I believe we should just replace  field_is_reference() with field_is_enumerable(), like this:
-            if (field_is_reference(fh)) {
+            if (field_is_enumerable(fh)) {
Or simply change the semantics of field_is_reference() - though this might be confusing in regards to internal Field API.
2) An assert is commented out in Ia32Inst.cpp due to warning - let's just fix this.

> [drlvm] VMMagic: migration to new interfaces
> --------------------------------------------
>
>                 Key: HARMONY-3126
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3126
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Mikhail Fursov
>         Assigned To: Alexey Varlamov
>         Attachments: vmmagic_1.zip
>
>
> This patch contains:
> 1) all VMmagics methods updated to use annotations-like pragmas instead of obsolete exception-like
> 2) vmmagic.jar location is updated to point to the new version. Run 'build update' before building drlvm
> 3) method_has_annotation was added to VM interfaces
> 4) magic types were removed from VM/GC enumeration
> 5) some refactoting was done to simplefy EM64T port (I hope it were all VM/GC changes needed)
> 6) minor bugfixes and improvements

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.