You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/02 11:11:13 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #24195:
[SPARK-25496][SQL] Deprecate from_utc_timestamp and to_utc_timestamp
cloud-fan commented on a change in pull request #24195: [SPARK-25496][SQL] Deprecate from_utc_timestamp and to_utc_timestamp
URL: https://github.com/apache/spark/pull/24195#discussion_r271248668
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala
##########
@@ -342,52 +342,55 @@ class StreamingAggregationSuite extends StateStoreMetricsTest with Assertions {
}
testWithAllStateVersions("prune results by current_date, complete mode") {
- import testImplicits._
- val clock = new StreamManualClock
- val tz = TimeZone.getDefault.getID
- val inputData = MemoryStream[Long]
- val aggregated =
- inputData.toDF()
- .select(to_utc_timestamp(from_unixtime('value * DateTimeUtils.SECONDS_PER_DAY), tz))
Review comment:
this test was here long time ago, why we can pass test 4 days ago?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org