You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by "Manikandan R (Jira)" <ji...@apache.org> on 2021/05/25 16:14:00 UTC
[jira] [Commented] (YUNIKORN-678) Refactoring REST API re-design
changes in handlers.go, handlers_test.go
[ https://issues.apache.org/jira/browse/YUNIKORN-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351172#comment-17351172 ]
Manikandan R commented on YUNIKORN-678:
---------------------------------------
[~cheersyang]
Currently context object doesn't have rmID unlike partition object. context#partitions map key contains both rmID and partition name. To address #3, we need to have a different map whose key has only partition name. If this can cause introduce a issue when having same partition name among different clusters, then, we will need to introduce rmID as context variable to know which rmID this particular context object has been associated with and concatenate this rmID with partition name before checking its presence in context#partitions map. Thoughts?
> Refactoring REST API re-design changes in handlers.go, handlers_test.go
> -----------------------------------------------------------------------
>
> Key: YUNIKORN-678
> URL: https://issues.apache.org/jira/browse/YUNIKORN-678
> Project: Apache YuniKorn
> Issue Type: Sub-task
> Reporter: Manikandan R
> Assignee: Manikandan R
> Priority: Major
> Labels: pull-request-available
>
> Tasks:
> 1. Avoid repeating "Partition not found", "Queue not found" etc asserts.
> 2. Make use of utils.GetNormalizedPartitionName to avoid cluster id in partition name
> 3. Address https://github.com/apache/incubator-yunikorn-core/pull/224#discussion_r636531149
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org